Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using type names in place of class names #118

Merged
merged 25 commits into from
Feb 23, 2023
Merged

Allow using type names in place of class names #118

merged 25 commits into from
Feb 23, 2023

Conversation

TamasSzigeti
Copy link
Contributor

@TamasSzigeti TamasSzigeti commented Sep 1, 2022

Introduce bundle config to map keys to class names

See #63

Allow custom type aliases from bundle config or custom implementation.

Fix unrelated errors to make CI green:

  • Injecting backendEnumNormalizer as class_exists(BackedEnum::class) always returns false
  • Downgrade mysql password hashing for php <7.4

@TamasSzigeti
Copy link
Contributor Author

@dunglas Please have a look

@TamasSzigeti
Copy link
Contributor Author

bump @dunglas What do you think of this approach?

@bpolaszek
Copy link
Contributor

I personally often change class namespaces to better organize code, leading to thorny migrations, so that change would be very welcome!

I +1 👍

src/Bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/SerializerTrait.php Outdated Show resolved Hide resolved
src/TypeMapper.php Outdated Show resolved Hide resolved
@TamasSzigeti
Copy link
Contributor Author

@dunglas Addressed change reqs, added tests and notes in readme.

@TamasSzigeti TamasSzigeti marked this pull request as ready for review October 17, 2022 09:22
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left some minor comments but overall it looks good to me.

src/Bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/TypeMapper.php Outdated Show resolved Hide resolved
@TamasSzigeti
Copy link
Contributor Author

@dunglas Also fixed some unrelated issues to make CI green

@amenophis
Copy link
Contributor

@dunglas any chance to see this merge soon ?
Can I help with something ?

Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay. The overall design looks good to me. Here are some last few comments. Thanks for working on this!!

src/Bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/Bundle/Resources/config/services.xml Outdated Show resolved Hide resolved
@amenophis
Copy link
Contributor

@TamasSzigeti Do you want to make the modification proposed by @dunglas ?
If you don't have time, i can do it !

Let me know 🙂

@TamasSzigeti
Copy link
Contributor Author

Thanks for the review, Kévin!

@amenophis Thanks for the offer, go ahead if you wish, otherwise I can take care of it this weekend.

@amenophis
Copy link
Contributor

Hi @TamasSzigeti,

Seems you did not had time to push update.
Could you give me permissions to push on your fork and will try to fix last comments ?

Thanks

@TamasSzigeti
Copy link
Contributor Author

@dunglas Comments addressed

@amenophis Thanks, just did it (:

@Guite
Copy link

Guite commented Feb 14, 2023

Really nice feature 👍

Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TamasSzigeti
Copy link
Contributor Author

@dunglas Comments addressed plus I fixed the workflow again:

  • Switched to using mysql from container as somehow setting legacy auth started failing.
  • Enable tests on php 8.2
  • doctrine/annotations has to become a direct dependency for latest versions

Might be worth dropping unsupported php and symfony versions in another PR

@dunglas dunglas merged commit 9ad0d28 into dunglas:main Feb 23, 2023
@dunglas
Copy link
Owner

dunglas commented Feb 23, 2023

Thank you very much for your hard work @TamasSzigeti!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants