docs: add custom Caddy modules #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+51
| FROM dunglas/frankenphp:latest-builder AS builder | ||
|
|
||
| # Copy xcaddy in the builder image | ||
| COPY --from=caddy:builder /usr/bin/xcaddy /usr/bin/xcaddy |
There was a problem hiding this comment.
Is there any reason that dunglas/frankenphp:latest-builder doesn't already come with xcaddy? I think that would save a line here.
There was a problem hiding this comment.
Just because we don't use xcaddy for the official builds: https://github.com/dunglas/frankenphp/blob/main/caddy/frankenphp/main.go
There was a problem hiding this comment.
I guess that's only because of maxprocs? I figure a super simple plugin that just has an init() which does that would make sense.
There was a problem hiding this comment.
It's temporarily for maxprocs, but also because I had a lot of issues with xcaddy in the past and followed the advice of using custom main.go file 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267.