fix(caddy): set default write timeout in transport URL

dunglas · May 24, 2023 · 9bef751 · 9bef751
1 parent 3863477
commit 9bef751
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/caddy/caddy.go b/caddy/caddy.go
@@ -140,12 +140,16 @@ func (m *Mercure) Provision(ctx caddy.Context) error { //nolint:funlen
 			return nil, fmt.Errorf("invalid transport url: %w", err)
 		}
 
-		if m.WriteTimeout != nil {
-			query := u.Query()
-			if !query.Has("write_timeout") {
-				query.Set("write_timeout", time.Duration(*m.WriteTimeout).String())
-				u.RawQuery = query.Encode()
+		const writeTimeoutKey = "write_timeout"
+		query := u.Query()
+		if !query.Has(writeTimeoutKey) {
+			if m.WriteTimeout == nil {
+				query.Set(writeTimeoutKey, mercure.DefaultWriteTimeout.String())
+			} else {
+				query.Set(writeTimeoutKey, time.Duration(*m.WriteTimeout).String())
 			}
+
+			u.RawQuery = query.Encode()
 		}
 
 		transport, err := mercure.NewTransport(u, m.logger)