chore: fix linters

dunglas · Aug 10, 2022 · e16de2e · e16de2e
1 parent df2b2ce
commit e16de2e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,7 +29,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v2
       with:
-        go-version: '1.18'
+        go-version: '1.19'
 
     - uses: actions/cache@v2
       with:

diff --git a/subscribe.go b/subscribe.go
@@ -12,6 +12,8 @@ import (
 )
 
 // SubscribeHandler creates a keep alive connection and sends the events to the subscribers.
+//
+//nolint:funlen,gocognit
 func (h *Hub) SubscribeHandler(w http.ResponseWriter, r *http.Request) {
 	assertFlusher(w)
 

diff --git a/subscribe_test.go b/subscribe_test.go
@@ -797,13 +797,15 @@ func TestSubscribeExpires(t *testing.T) {
 	jwt, err := token.SignedString(hub.subscriberJWT.key)
 	require.Nil(t, err)
 
-	req := httptest.NewRequest("GET", defaultHubURL+"?topic=foo", nil)
+	req := httptest.NewRequest(http.MethodGet, defaultHubURL+"?topic=foo", nil)
 	req.Header.Add("Authorization", "Bearer "+jwt)
 
 	w := httptest.NewRecorder()
 	hub.SubscribeHandler(w, req)
 
 	resp := w.Result()
+	defer resp.Body.Close()
+
 	assert.Equal(t, 200, resp.StatusCode)
 }