Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible lost of updates #179

Closed
wants to merge 1 commit into from
Closed

Fix possible lost of updates #179

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Oct 10, 2019

Close #178

@dunglas dunglas mentioned this pull request Oct 10, 2019
Closed
jderusse
jderusse reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an issue if updates are sent?:

  • twice
  • unsorted

@dunglas
Copy link
Owner Author

dunglas commented Oct 10, 2019

The order isn't guaranteed, by the spec (it's difficult to guarantee order in clustered mode). However we should prevent to send updates twice, so this patch isn't enough.
Maybe could we add a ready flag to the subscriber struct, set it to true immediately after sendMissedUpdate, and start broadcasting new updates only when ready is true. Will probably have to implement some synchronization mechanism too.

@dunglas
Copy link
Owner Author

dunglas commented Oct 23, 2019

Closing in favor of #181, which is a better and cleaner approach!

@dunglas dunglas closed this Oct 23, 2019
@dunglas dunglas deleted the fix_178 branch October 23, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible lost of update
2 participants
@dunglas @jderusse