Add a chat demo using Flask (Python) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toofff
reviewed
Nov 26, 2018
Gregcop1
reviewed
Nov 26, 2018
Gregcop1
reviewed
Nov 26, 2018
tlenclos
reviewed
Nov 27, 2018
| e.preventDefault() | ||
|
|
||
| const body = new URLSearchParams({ | ||
| data: JSON.stringify({ username: this.elements.username.value, message: this.elements.message.value }), |
There was a problem hiding this comment.
Why do you need to send the username if the user is logged ?
There was a problem hiding this comment.
It is authorized to subscribe and to post to the hub, not really "logged in" (I mean it is authorized but not authenticated).
A proper login system could be added to the Python app (if appropriate), then the username could be set in the dedicated JWT claim, and sent along with the message. But then I think that it would be more efficient (and more secure) to send new messages to the Python app, that will then send them (including the current username) to the hub.
aslafy-z
reviewed
Nov 29, 2018
| ) | ||
|
|
||
| hub_url = os.environ.get('HUB_URL', 'http://localhost:3000/hub') | ||
| topic = os.environ.get('HUB_URL', 'http://example.com/chat') |
There was a problem hiding this comment.
I think this env variable has to be TOPIC, not HUB_ URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example of a real-time chat app in 23 lines of Python (2 dependencies: the Flask microframework and PyJWT) and 35 lines of JavaScript (0 dependencies). Of course it benefits from built-in capabilities of the Mercure protocol: HTTP/2/HTTP/3 compatibility, automatic reconnection with re-fetching of missed messages, authentication...
live demo
Flask is only used to handle the authentication part (cookie method) and to serve the HTML layout. The chat system itself uses directly the Mercure hub.
馃樆
Closes #12.