Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Ristretto to manage the topic selector cache #429

Merged
merged 2 commits into from Jan 5, 2021
Merged

feat: use Ristretto to manage the topic selector cache #429

merged 2 commits into from Jan 5, 2021

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Dec 21, 2020 •
edited

Should fix #388, improve memory usage for everybody and save some CPU cycles.

  • Use Ristretto instead of our naive cache
  • Upgrade yosida95/uritemplate to v3
  • Expose Ristretto's config
  • Find good values for costs
  • Write better tests

@dunglas dunglas force-pushed the feat/ristretto branch 4 times, most recently from d73bbf1 to 0264283 Compare January 5, 2021 00:25
@dunglas dunglas marked this pull request as ready for review January 5, 2021 00:28
@dunglas dunglas merged commit 86b5848 into main Jan 5, 2021
@dunglas dunglas deleted the feat/ristretto branch January 5, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leaking
1 participant
@dunglas