-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for metrics in chart #924
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: François BIBRON <francois.bibron@ext.soprasteria.com>
Do we also want to add support for prometheus service monitor? https://observability.thomasriley.co.uk/prometheus/configuring-prometheus/using-service-monitors/ In this case it would be automatically be picked up by prometheus-operator running on my cluster :D |
Signed-off-by: François BIBRON <francois.bibron@ext.soprasteria.com>
Signed-off-by: François BIBRON <francois.bibron@ext.soprasteria.com>
I totally agree with you, I added the corresponding changes. |
Signed-off-by: François BIBRON <francois.bibron@ext.soprasteria.com>
Signed-off-by: François BIBRON <francois.bibron@ext.soprasteria.com>
LGTM |
This PR adds a specific port for the metrics in the Helm Chart.