fix: content truncated because response end is called too early

dunglas · Dec 5, 2020 · ecbde66 · ecbde66
1 parent 59088ba
commit ecbde66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/src/server.test.tsx b/src/server.test.tsx
@@ -73,10 +73,7 @@ test("serveFragment with pipeStream option", async () => {
             callback(undefined, "<div>hi there</div>");
           },
         });
-        input.pipe(
-          transformer,
-          { end: false }
-        );
+        input.pipe(transformer);
         return transformer;
       },
     })

diff --git a/src/server.tsx b/src/server.tsx
@@ -168,17 +168,9 @@ export async function serveFragment(
   );
 
   const removeReactRootStream = new RemoveReactRoot();
-  stream.pipe(
-    removeReactRootStream,
-    { end: false }
-  );
+  stream.pipe(removeReactRootStream);
 
   const lastStream: NodeJS.ReadableStream =  options.pipeStream ? options.pipeStream(removeReactRootStream) : removeReactRootStream;
 
-  lastStream.pipe(
-    res,
-    { end: false }
-  );
-
-  stream.on("end", () => res.end());
+  lastStream.pipe(res);
 }