Feature - add typescript declarations #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this awesome library.
With this PR, I'd like to add typings to the package.
There were a couple of issues with typing withESI:
React.ComponentClass<P & IWithESIProps>
propTypes
member did not account for child properties as provided by the generic variableP
. This generated another typescript error. I resolved it by converting the propTypes member first to unknown and then to the properWeakValidationMap
type to account for HOC props and the children props.