Feature - add option to further pipe stream #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
May 18, 2020
src/server.tsx
Outdated
| const removeReactRootStream = new RemoveReactRoot(); | ||
| stream.pipe( | ||
| removeReactRootStream, | ||
| { end: false } | ||
| ); | ||
| removeReactRootStream.pipe( | ||
|
|
||
| let lastStream: NodeJS.ReadableStream = removeReactRootStream; |
There was a problem hiding this comment.
Suggested change
| let lastStream: NodeJS.ReadableStream = removeReactRootStream; | |
| const lastStream: NodeJS.ReadableStream = options.pipeStream ? options.pipeStream(removeReactRootStream) : removeReactRootStream; |
There was a problem hiding this comment.
Thanks that is cleaner indeed. I've added it in commit 047a3db:
const lastStream: NodeJS.ReadableStream = options.pipeStream ? options.pipeStream(removeReactRootStream) : removeReactRootStream;
|
Thanks @dpnolte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR aims to expose the serveFragment stream to the library user. That is, an option to provide any extra pipes on the stream is provided. With this option, users can further transform the fragment output as desired. I created this PR because I needed to add rendered styles from emotion to the served fragment.
Changes:
I'd be happy to implement any desired changes.