Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building using specific symfony version #11

Merged
merged 1 commit into from Jun 16, 2018

Conversation

mateuszsip
Copy link
Contributor

Hi,
I've seen a question about installing specific symfony version on symfony slack and thought it could be supported here.

Not sure about VERSION default value in compose, but we'll probably figure it out.

What do you think?

@dunglas
Copy link
Owner

dunglas commented Oct 27, 2017

@dunglas
Copy link
Owner

dunglas commented Jun 14, 2018

ping @kejwmen, do you want me to finish this one?

@reypm
Copy link

reypm commented Jun 14, 2018

@dunglas I am not the owner of this but yeah it would be great if you finish this and add it to the stack 💯

@mateuszsip
Copy link
Contributor Author

Sorry, I forgot about this PR and thought there was a similiar one, already merged.

I will finish it later today.

@mateuszsip mateuszsip force-pushed the feature/select-skeleton-version branch from 89cfccc to 0ab47a2 Compare June 15, 2018 22:40
@mateuszsip
Copy link
Contributor Author

Done, sorry for delay ;)

@mateuszsip
Copy link
Contributor Author

should we add a README to document this behavior?

@dunglas
Copy link
Owner

dunglas commented Jun 16, 2018

Yes it would be awesome to add a README.

@dunglas dunglas merged commit 5f03437 into dunglas:master Jun 16, 2018
@dunglas
Copy link
Owner

dunglas commented Jun 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants