Improve async loop

dunglas · Nov 21, 2019 · ee3cabd · ee3cabd
1 parent d3ea648
commit ee3cabd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/fixtures/static/index.html b/fixtures/static/index.html
@@ -1,2 +1,3 @@
 <h1>HTTP/2 Fixtures</h1>
+<pre><code id="result"></code></pre>
 <script src="/main.js"></script>
diff --git a/fixtures/static/main.js b/fixtures/static/main.js
@@ -1,6 +1,7 @@
 const apiURL = "https://localhost:3000";
 
 const cache = {};
+const result = document.getElementById('result');
 async function fetchRel(rel) {
   // Prevent fetching twice the same relation
   if (cache[rel]) {
@@ -19,15 +20,14 @@ async function fetchRel(rel) {
 
 (async function() {
   const books = await fetchRel("/books.jsonld?preload=/hydra:member/*/author");
+  result.innerText = JSON.stringify(books, null, 2);
 
-  for (let i = 0; i < books["hydra:member"].length; i++) {
-    books["hydra:member"][i] = await fetchRel(books["hydra:member"][i]);
-    books["hydra:member"][i].author = await fetchRel(
-      books["hydra:member"][i].author
-    );
-  }
-
-  document.write(`<pre><code>${JSON.stringify(books, null, 2)}</code></pre>`);
+  books["hydra:member"].forEach(async (bookId, i) => {
+    const book = await fetchRel(bookId);
+    book.author = await fetchRel(book.author);
+    books["hydra:member"][i] = book;
+    result.innerText = JSON.stringify(books, null, 2);
+  });
 
   return books;
 })();