Prepare for new release #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds jekyll-octicons as a default dependency of pages-gem. It was being added later on in the github pages chain of tools so it was available, but just not from here in pages-gem. It seems the intent there *might* have been to not pin octicons down to a specific version, therefore making it easier to get the latest versions. This seems to have failed, given it was pinned to 14.x while they are now up to 19.x. Not sure where it was when I forked this, but still, definitely wasn't on the latest major version. Also bumped rouge to its latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few updates:
setup-buildx-actionto docker workflowjekyll-octiconsdependency & bumprougeMore info about the thinking behind adding
jekyll-octicons:Adds
jekyll-octiconsas a default dependency of pages-gem. It was being added later on in the github pages chain of tools so it was available, but just not from here in pages-gem. It seems the intent there might have been to not pin octicons down to a specific version, therefore making it easier to get the latest versions. This seems to have failed, given it was pinned to 14.x while they are now up to 19.x. Not sure where it was when I forked this, but still, definitely wasn't on the latest major version.