SSR bypass

[oori]

It breaks SSR, as no window is defined. There are various workarounds, but it's nicer handled in the library itself by checking for window.

I thought it's only this line, but your build adds bindings to window .call(window).

Thanks!

[dunnock]

Hi, unfortunately Sigma.js is tightly coupled with window, though if you import following script in the same namespace but before react-sigma it should do the job: https://github.com/jacomyal/sigma.js/blob/master/src/sigma.export.js

…

On Wed, Sep 13, 2017 at 11:46 PM, Oori ***@***.***> wrote: It breaks SSR, as no window is defined. There are various workarounds <https://reactql.org/docs/ssr/environment>, but it's nicer handled in the library itself by checking for window <webpack/react-starter#37 (comment)> . I thought it's only this line <https://github.com/dunnock/react-sigma/blob/f25d7f1251ac22ffe31d785dffdbf5b67e0f44b1/sigma-src/main.js#L45>, but your build adds bindings to window .call(window). Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#44>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYtIKFC8y0bNmesaGRKv2VuvKq8RBDsks5siD8igaJpZM4PWtAW> .

-- Cheers, Maxim

[dunnock]

Hi @oori , did it help? If so can you please close this issue, if not please let me know.. Thanks

[oori]

@dunnock Thanks for your message. No, it did not help, build still breaks. unfortunately I didn't have time to dig into this, and just bypassed the issue temporarily. I will have to resolve this sooner or later.. and will update with details here.

[leofle]

some news in here?

[keplersj]

Using react-async-component with serverMode set to 'defer' works really well for this use case. Works well with Gatsby/Next.js setups as well.