notification-history.sh: Rewrite for speed

- My main intention is minimize calls to jq since (on my thinkpad) each takes 50-100 ms, which can add up to a noticeable delay (~400ms for each notification) until the window first appears.

- This new version also fixes a bug where notification that contained newlines, those \ns were wrongly interpreted by the script
  Try: $ notify-send "The\ntrick"

- When selecting or reading a notification, the display format has changed from 1 to 2: The important information is prioritized left-to-right.
  1) 0003 - NetworkManager: "Wi-Fi Networks Available" (at 10:01:22 AM)
  2) "Wi-Fi Networks Available" (NetworkManager) - 10:01:22 AM - 0003

contrib/notification-history.sh

@@ -1,47 +1,55 @@
-#!/bin/bash
-
-history_json=$(dunstctl history)
-
-history_length=$(echo $history_json|jq -r '.data[] | length')
-
-options=""
-
-for iter in $(seq $history_length); do
-    i=$((iter-1))
-    application_name=$(echo $history_json|jq -r .data[][$i].appname.data)
-    notification_summary=$(echo $history_json|jq -r .data[][$i].summary.data)
-    notification_timestamp=$(echo $history_json|jq -r .data[][$i].timestamp.data)
+#!/bin/sh
+tests() {
+    #check if these get displayed right
+    notify-send "Dinner is ready"
+    notify-send "The\nTrick"
+    notify-send "The Trick
+#2"
+}
+
+history_json="$(dunstctl history)"
+history_items="$(printf '%s' "$history_json" | jq -r '.data[0][] | .appname.data , (.timestamp.data | tostring) , .summary.data | gsub("[\\n]"; "\\n")')" # the gsub is to really ensure no escaped new lines in the data lead us to print new lines. New lines in data have to be escaped. (Because) Actual newlines are the field separator essential to the logic of the while loop below, and rofi further down.
+
+#history_items ends up looking like arrays with an order with this meaning: 
+#appname (newline) timestamp (newline) summary (newline)
+#
+#NetworkManager
+#223948180
+#Wi-Fi Networks Available
+#
+#How do we know where this notification ends and another begins? By length, which is always 3 values.
+
+#history_length="$(($(echo "$history_items" | wc -l) / 3 ))"
+
+iter=0
+
+IFS='
+'
+while read -r application_name; read -r notification_timestamp ; read -r notification_summary
+do
+    iter=$((iter+1))
     system_timestamp=$(cat /proc/uptime|cut -d'.' -f1)
-
-    how_long_ago=$((system_timestamp-notification_timestamp/1000000))
-
+    how_long_ago=$((system_timestamp - notification_timestamp / 1000000))
     notification_time=$(date +%X -d "$(date) - $how_long_ago seconds")
 
-    option=$(printf '%04d - %s: "%s" (at %s)' "$iter" "$application_name" \
-        "$notification_summary" "$notification_time")
+    option=$(printf '"%s" (%s) - %s - %04d' "$notification_summary" "$application_name" "$notification_time" "$iter")
+
+    options="$options$option
+"
+done <<EOF
+$history_items
+EOF
 
-    options="$options$option\n"
-done
 options="$options""Cancel"
 
-result=$(echo -e $options|rofi -dmenu -i)
-if [ "$result" = "Cancel" ]; then
-    # Exit if cancelled
-    exit 0
-fi
-if [ "$result" = "" ]; then
-    # Exit on empty strings
-    exit 0
-fi
-if [ "$?" -ne 0 ]; then
-    # Exit on non-zero return values
-    exit 0
+result=$(printf '%s' "$options" | rofi -dmenu -i)
+if [ "$?" -ne 0 ] || [ -z "$result" ] || [ "$result" = "Cancel" ]; then
+    exit
 fi
 
 # Get the internal notification ID
-selection_index=$((${result:0:4}-1))
-notification_id=$(echo $history_json|jq -r .data[][$selection_index].id.data)
+selection_index=$(( $(printf '%s' "$result" | awk -F" " '{print $(NF-0)}') - 1)) # translation of awk: grab the last field
+notification_id=$(printf '%s' "$history_json" | jq -r .data[][$selection_index].id.data)
 
 # Tell dunst to revive said notification
 dunstctl history-pop $notification_id
-