Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dunstctl history command #1060

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

stremlenye
Copy link
Contributor

Removes -l option from the busctl invocation since it's only relevant to the list outputs.
That fixes the command to fail on invocation with an internal error

busctl: invalid option -- 'l'

See buctl(1)

Removes `-l` option from the `busctl` invocation since it's only relevant to the `list` outputs.
See [buctl(1)](https://www.freedesktop.org/software/systemd/man/busctl.html)
@fwsmit
Copy link
Member

fwsmit commented Mar 30, 2022

Weird that it didn't give that error earlier

@codecov-commenter
Copy link

Codecov Report

Merging #1060 (4fee122) into master (8aaa019) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files          45       45           
  Lines        7097     7097           
=======================================
  Hits         4351     4351           
  Misses       2746     2746           
Flag Coverage Δ
unittests 61.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aaa019...4fee122. Read the comment docs.

@fwsmit
Copy link
Member

fwsmit commented Apr 14, 2022

For me the dunstctl history command works, but it seems like removing the -l can't hurt, so I'll merge this PR. Thank you!

@fwsmit fwsmit merged commit dbcdd74 into dunst-project:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants