Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional id to dunstctl close #1351

Merged
merged 2 commits into from
May 3, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented May 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.95%. Comparing base (9fb0216) to head (14ecba5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          50       50           
  Lines        8209     8209           
  Branches      962      962           
=======================================
  Hits         5414     5414           
  Misses       2795     2795           
Flag Coverage Δ
unittests 65.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zappolowski zappolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.

@bynect
Copy link
Member Author

bynect commented May 2, 2024

Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.

right, forgot about that 👍🏻

@bynect
Copy link
Member Author

bynect commented May 2, 2024

@zappolowski I fixed some typos and updated the completions. Unfortunately we can't autocomplete the id (see my suggestion in #1348).

@bynect
Copy link
Member Author

bynect commented May 3, 2024

done.

unrelated question, should we add a completion for dunstify later?

@zappolowski
Copy link
Member

unrelated question, should we add a completion for dunstify later?

Yes, this would make sense. I just added it for fish as that's what I'm using.

@bynect bynect merged commit b00dca6 into dunst-project:master May 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants