Skip to content

Add an optional id to dunstctl close#1351

Merged
bynect merged 2 commits into
dunst-project:masterfrom
bynect:add-close-id
May 3, 2024
Merged

Add an optional id to dunstctl close#1351
bynect merged 2 commits into
dunst-project:masterfrom
bynect:add-close-id

Conversation

@bynect
Copy link
Copy Markdown
Contributor

@bynect bynect commented May 2, 2024

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.95%. Comparing base (9fb0216) to head (14ecba5).
⚠️ Report is 306 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          50       50           
  Lines        8209     8209           
  Branches      962      962           
=======================================
  Hits         5414     5414           
  Misses       2795     2795           
Flag Coverage Δ
unittests 65.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@zappolowski zappolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.

@bynect
Copy link
Copy Markdown
Contributor Author

bynect commented May 2, 2024

Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.

right, forgot about that 👍🏻

@bynect
Copy link
Copy Markdown
Contributor Author

bynect commented May 2, 2024

@zappolowski I fixed some typos and updated the completions. Unfortunately we can't autocomplete the id (see my suggestion in #1348).

Comment thread completions/_dunstctl.zshcomp
@bynect
Copy link
Copy Markdown
Contributor Author

bynect commented May 3, 2024

done.

unrelated question, should we add a completion for dunstify later?

@zappolowski
Copy link
Copy Markdown
Member

unrelated question, should we add a completion for dunstify later?

Yes, this would make sense. I just added it for fish as that's what I'm using.

@bynect bynect merged commit b00dca6 into dunst-project:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants