Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve user's home from passwd entry as fallback #694

Merged
merged 1 commit into from Mar 13, 2020
Merged

Retrieve user's home from passwd entry as fallback #694

merged 1 commit into from Mar 13, 2020

Conversation

bebehei
Copy link
Member

@bebehei bebehei commented Mar 10, 2020

For weird reasons, the HOME-variable might not always be set. So we
should fallback on something more reliable.

Fixes #693

@bebehei
Retrieve user's home from passwd entry as fallback
9591af0 
For weird reasons, the HOME-variable might not always be set. So we
should fallback on something more reliable.

Fixes dunst-project#693
@bebehei bebehei requested a review from tsipinakis March 10, 2020 15:34
@bebehei bebehei added the Bug label Mar 10, 2020
@bebehei bebehei mentioned this pull request Mar 10, 2020
Closed
tsipinakis
tsipinakis approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets wait and see if it actually resolves the issue before merging

@tsipinakis tsipinakis merged commit fbdef7b into dunst-project:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsipinakis tsipinakis tsipinakis approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault and memory errors
2 participants
@bebehei @tsipinakis