Skip to content

Set cursor to left_ptr when mouse is over a notification on wayland#903

Merged
fwsmit merged 1 commit into
dunst-project:masterfrom
GorrillaRibs:master
Sep 17, 2021
Merged

Set cursor to left_ptr when mouse is over a notification on wayland#903
fwsmit merged 1 commit into
dunst-project:masterfrom
GorrillaRibs:master

Conversation

@GorrillaRibs

Copy link
Copy Markdown
Contributor

As in mako here: emersion/mako@85a3e38

Currently (on wayland) the cursor remains what it was when the mouse enters the notification window (i.e. from a terminal or a text entry box it'll be a vertical bar), this fixes that.

Code is taken from mako (which used to have the same issue) and adapted a little to fit dunst.

@codecov-commenter

codecov-commenter commented Sep 10, 2021

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (3055efd) to head (e6222d8).
⚠️ Report is 835 commits behind head on master.

Files with missing lines Patch % Lines
src/wayland/wl.c 0.00% 30 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
- Coverage   60.50%   60.21%   -0.30%     
==========================================
  Files          39       39              
  Lines        6228     6258      +30     
==========================================
  Hits         3768     3768              
- Misses       2460     2490      +30     
Flag Coverage Δ
unittests 60.21% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fwsmit fwsmit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this patch. I've got a few style comments, but other than that it looks good

Comment thread config.mk Outdated
Comment thread src/wayland/wl.c
Comment thread src/wayland/wl.c Outdated
Comment thread src/wayland/wl.h Outdated
@GorrillaRibs

Copy link
Copy Markdown
Contributor Author

I think I've fixed everything brought up, but I haven't really used pull requests on github before, so I might've missed something - please let me know if there's any issues!

@fwsmit

fwsmit commented Sep 13, 2021

Copy link
Copy Markdown
Member

@GorrillaRibs Looks great! If you could squash the commits into the first one I'll merge the PR.

@GorrillaRibs

Copy link
Copy Markdown
Contributor Author

Done!

@fwsmit fwsmit merged commit 91c6e93 into dunst-project:master Sep 17, 2021
@fwsmit

fwsmit commented Sep 17, 2021

Copy link
Copy Markdown
Member

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants