Set cursor to left_ptr when mouse is over a notification on wayland #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
- Coverage 60.50% 60.21% -0.30%
==========================================
Files 39 39
Lines 6228 6258 +30
==========================================
Hits 3768 3768
- Misses 2460 2490 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fwsmit
requested changes
Sep 10, 2021
GorrillaRibs
force-pushed
the
master
branch
from
400a464
to
f23e038
Compare
|
I think I've fixed everything brought up, but I haven't really used pull requests on github before, so I might've missed something - please let me know if there's any issues! |
|
@GorrillaRibs Looks great! If you could squash the commits into the first one I'll merge the PR. |
fwsmit
approved these changes
Sep 13, 2021
GorrillaRibs
force-pushed
the
master
branch
from
4c859f8
to
e6222d8
Compare
|
Done! |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in mako here: emersion/mako@85a3e38
Currently (on wayland) the cursor remains what it was when the mouse enters the notification window (i.e. from a terminal or a text entry box it'll be a vertical bar), this fixes that.
Code is taken from mako (which used to have the same issue) and adapted a little to fit dunst.