-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling for new firmware version style seems to be incorrect #28
Comments
Apple changed the way it displays the EFI version, so this may be an issue for everybody now. |
There does seem to be code added to handle this, but it doesn't seem to be working correctly ... at least in this case. |
Hi @swrobel and @alvarnell, Are you seeing these issues with the latest version of the EFIgy client? If I change add the following at line 396 I'm still seeing
Also, you're right that check.efigy.io and EFIgy-GUI haven't been updated to parse the newer version format, but I just added that to EFIgy-GUI here: I haven't released a new version yet but if you feel so inclined go ahead and try the updated build. I'll try to release an updated version soon. Thanks! |
@futureimperfect yes, I tested with latest master & just checked the code to verify and it's still failing with |
@swrobel, the master hasn't been updated yet. You will need to substitute https://github.com/duo-labs/EFIgy/blob/master/EFIgyLite_cli.py in order to use the new changes. |
Hi @swrobel and @alvarnell, You're totally right. The updates I made recently didn't take into account the newer EFI version style when checking EFI only. I just updated the dataset again, so it should work now. Feel free to reopen this issue if not! Thanks! |
Using both check.efigy.io and EFIgy GUI I get this mismatch:
Your EFI version is not what we expected.
You're running 166.0.0.0.0, but we expected you to be running IM171.0166.B00.
The CLI does not report the expected version, but says
Your firmware version 166.0.0 is older than expected for a iMac17,1 running build 18F132. You should update your EFI firmware
Model: iMac17,1
Build: 18F132
The text was updated successfully, but these errors were encountered: