Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ALBs and NLBs in addition to ELBs #22

Closed
pdehlke opened this issue Feb 21, 2018 · 4 comments
Closed

Support ALBs and NLBs in addition to ELBs #22

pdehlke opened this issue Feb 21, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pdehlke
Copy link

pdehlke commented Feb 21, 2018

Collecting the data in collect_data.sh is pretty simple, but I don't stand a snowball's chance of being able to produce a PR for the python bits :)

Thanks!

@0xdabbad00 0xdabbad00 added the enhancement New feature or request label Feb 26, 2018
@JulesDT
Copy link
Contributor

JulesDT commented Feb 26, 2018

I can probably do that. Do we agree that (in terms of AWS CLI)
aws elb describe-load-balancers gives you the ELBs
aws elbv2 describe-load-balancers gives you the ALBs and NLBs ?

Obviously AWS didn't make this easy so the JSON Blobs structure is different, but no big deal.
Could someone eventually give some demo data so that I can test my code ?

@JulesDT
Copy link
Contributor

JulesDT commented Mar 1, 2018

Opened a PR (#61) to solve this issue, but I couldn't test it.

@0xdabbad00 0xdabbad00 added the help wanted Extra attention is needed label Mar 1, 2018
@0xdabbad00
Copy link
Collaborator

Thank you @JulesDT! I'd like someone else to test this with real data, and if possible update the demo data with some munged data so the unit tests run over this. I can spin up an ALB and NLB quickly if no one else already has one in their environment.

@0xdabbad00
Copy link
Collaborator

ALB and NLB support should work now thanks to @JulesDT and @heikkiv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants