Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples splunk.py is using python 2 import #110

Closed
dpwildboar opened this issue May 1, 2020 · 0 comments · Fixed by #151
Closed

examples splunk.py is using python 2 import #110

dpwildboar opened this issue May 1, 2020 · 0 comments · Fixed by #151

Comments

@dpwildboar
Copy link

examples splunk.py is using python 2 import

For proxy support

from urlparse import urlparse

should be for python 3

from urllib.parse import urlparse

see:

https://docs.python.org/2/library/urlparse.html

top of page says:

Note The urlparse module is renamed to urllib.parse in Python 3. The 2to3 tool will automatically adapt imports when converting your sources to Python 3.

python 3.7 docs:

https://docs.python.org/3.7/library/urllib.parse.html#module-urllib.parse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant