Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI-tested Python3 versions #44

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

petiepooo
Copy link
Contributor

@petiepooo petiepooo commented Feb 16, 2023

Remove python v3.6 and add v3.10

Remove v3.6 and v3.10 and v3.11
Numerically, the float 3.10 == 3.1.  Trying a quote so it treats it as a string and leaves the trailing 0 intact...
Until mox is updated, the test framework is incompatible with python3.11.  inspect.getargspec() has been deprecated.
@petiepooo
Copy link
Contributor Author

That was not so smooth..
As a float, 3.10 == 3.1, so trying to add 3.10 unquoted attempted to use python 3.1. Quoting 3.10 so it was treated as a string instead of a float worked.
Also, unfortunately, mox is using the inspect.getargspec() function, which is deprecated and has been removed in python 3.11. Until that is updated, the testing framework does not work.
For consistency, all python versions are now quoted, since semantic version numbers are strings, not floats.
I think this patch is ready, and should also fix the failure seen in #43

@petiepooo petiepooo changed the title Update available Python3 versions Update CI-tested Python3 versions Feb 16, 2023
@AaronAtDuo AaronAtDuo merged commit b1c4c66 into duosecurity:master Feb 16, 2023
@petiepooo petiepooo deleted the patch-1 branch February 17, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants