Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msvc build and windows compatibility #7

Closed

Conversation

himynameschris
Copy link

Function calls such as setenv and fork are not native to the windows C libraries and fork has no equivalent. This module leaves the posix-related codes alone to maintain backwards compatibility, while enabling msvc builds. A script to build on windows with msvc is also added.

Chris Hannon added 4 commits August 28, 2015 12:29
for windows / msvc compatibility:
-uses popen instead of execvp to execute python or perl script due to lack of support
-replaces setenv with putenv_s due to lack of support
-adds _MSVC compiler option to properly export dll functions (declspec)

Signed-off-by: Chris Hannon <chris@channon.us>
…ates Makefile with minor changes to the path passed to the compiler

Signed-off-by: Chris Hannon <chris@channon.us>
…on-msvc environment

Signed-off-by: Chris Hannon <chris@channon.us>
Signed-off-by: Chris Hannon <chris@channon.us>
Copy link
Contributor

@petiepooo petiepooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the capability of compiling under MSVC is still desired, please bring this up to date with the current release.
Also please avoid unbounded string functions like strcat() and strcpy() in favor of explicitly bounded functions like strncat() and strncpy().

@AaronAtDuo
Copy link
Contributor

Closing out this old PR

@AaronAtDuo AaronAtDuo closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants