Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build date from git and dont add debug info by default #264

Merged
merged 1 commit into from Jan 30, 2024

Conversation

mbish
Copy link
Contributor

@mbish mbish commented Sep 27, 2023

Issue number being addressed

It will help us identify unmodified binaries if our build process results in reproducable binaries
for a given environment.

Summary of the change

This diff accomplishes that by

  1. Removing debugging information by default (compiling with -g0)
  2. Attempting to establish a build date from the current commit if the working directory is clean

Test Plan

Manually tested. Automated testing of this behavior is probably a good idea since there are
enough different cases here but that will have to happen in the apps-testing repo if this PR is adopted.

@mbish mbish merged commit f10ff96 into duosecurity:master Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants