--use-move-for-put option is broken

[SamiLehtinen]

• I have searched open and closed issues for duplicates.
• I have searched the forum for related topics.

---

Environment info

• Duplicati version: Release: 2.0.6.103 (canary) 2022-06-12
• Operating system: Ubuntu
• Backend: Local file system

Description

--use-move-for-put local option is broken with latest changes (works with previous canary release)

Steps to reproduce

1. Have temp and database on same volume
2. add --use-move-for-put option to improve performance, move files instead copy from temp to the destination
3. fails with following error

• Actual result:
  File transfer fails with exception.
• Expected result:
  No exception, file moved from temp to destination.

Debug log

Backend event: Put - Started: duplicati-bcce79348bc594747a4526929810a8c2c.dblock.zip.aes (123.22 KB)
  Uploading file (123.22 KB) ...
Operation Put with file duplicati-bcce79348bc594747a4526929810a8c2c.dblock.zip.aes attempt 1 of 6 failed with message: Source file does not exist. Source: /mnt/s2/Temp-Duplicati/dup-af9126a0-65df-4c89-ae5b-1ca0b0cd7ea5 => Duplicati.Library.Interface.FileMissingException: Source file does not exist. Source: /mnt/s2/Temp-Duplicati/dup-af9126a0-65df-4c89-ae5b-1ca0b0cd7ea5
  at Duplicati.Library.Backend.File.VerifyMatchingSize (System.String targetFilePath, System.String sourceFilePath) [0x00083] in <4a02c7b559f449fd8f810d656f073479>:0 
  at Duplicati.Library.Backend.File.PutAsync (System.String targetFilename, System.String sourceFilePath, System.Threading.CancellationToken cancelToken) [0x00043] in <4a02c7b559f449fd8f810d656f073479>:0 
  at Duplicati.Library.Main.Operation.Backup.BackendUploader.DoPut (Duplicati.Library.Main.Operation.Common.BackendHandler+FileEntryItem item, Duplicati.Library.Interface.IBackend backend, System.Threading.CancellationToken cancelToken) [0x004c5] in <47c3dcd712424c6cb21da3ff3e78f9eb>:0 
  at Duplicati.Library.Main.Operation.Backup.BackendUploader+<>c__DisplayClass20_0.<UploadFileAsync>b__0 () [0x0010a] in <47c3dcd712424c6cb21da3ff3e78f9eb>:0 
  at Duplicati.Library.Main.Operation.Backup.BackendUploader.DoWithRetry (System.Func`1[TResult] method, Duplicati.Library.Main.Operation.Common.BackendHandler+FileEntryItem item, Duplicati.Library.Main.Operation.Backup.BackendUploader+Worker worker, System.Threading.CancellationToken cancelToken) [0x00198] in <47c3dcd712424c6cb21da3ff3e78f9eb>:0 

Note, easy workaround is to remove the option. But of course it adds lot of unnecessary disk i/o.

[duplicatibot]

This issue has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/release-2-0-6-103-canary-2022-06-12/14612/3

[kenkendk]

Doooh! The check verifies that the source and destination files have the same length, but of course this fails when the source file is moved. This is caused by #4691