Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed runs missing from the job-specific log page #4829

Closed
2 tasks done
taz-il opened this issue Oct 15, 2022 · 3 comments
Closed
2 tasks done

Failed runs missing from the job-specific log page #4829

taz-il opened this issue Oct 15, 2022 · 3 comments

Comments

@taz-il
Copy link
Contributor

taz-il commented Oct 15, 2022

  • I have searched open and closed issues for duplicates.
  • I have searched the forum for related topics.

Environment info

  • Duplicati version: 2.0.6.3_beta_2021-06-17
  • Operating system: Win 11 Pro, 22H2
  • Backend: FTP

Description

When a backup job fails, the failures only appear on the general server page (the one for all backups), and not on the log page of the individual backup job that failed. As an example, I have this job running daily. It failed consecutively on Oct 1, 2, 3, etc, but these failures don't show up (is it only for me? is this the intended behavior for some reason?)

Steps to reproduce

This happens with every backup failure, so in order to reproduce, just cause a backup to fail (e.g. wrong user/pass for FTP; or any other way).

  • Actual result:
    image
  • Expected result:
    image

Expected: all backup attempts show up in the log (not only the successful ones), with a minimum of "Backup failed" title, ideally with some short description of the error (e.g. "host unreachable"), but this latter part is of course lower prio.

@ts678
Copy link
Collaborator

ts678 commented Oct 23, 2022

This sounds like Combine logs in GUI #1152. Sounds undesired and unintended but due to unstated technical reasons.
My usual guess (not confirmed by anybody knowing code well) is that the job logs (see Complete log) are results like:

public interface IBackupResults : IBasicResults, IBackendStatsticsReporter

public interface IBasicResults

The database LogData table looks like a backup actually writes the results when it has them -- unless it errors out early.

public void LogMessage(string type, string message, Exception exception, System.Data.IDbTransaction transaction)

image

Even though the log is structured data, I don't know why there couldn't be a version with a little error info and no more.
Possibly it has to do with how the exceptions flow. If anyone does C# and would like to look, take the above as starters...
I would definitely love to see this improved, but somebody needs to volunteer, and volunteers are extremely scarce now.

@duplicatibot
Copy link

This issue has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/improve-result-reporting/16407/17

Jojo-1000 added a commit to Jojo-1000/duplicati that referenced this issue Jun 23, 2023
Add a new 'Interrupted' field to IBasicResult.
Interrupted and failed backups are recorded in the job log (duplicati#4829).
When the backup is interrupted or fails, metadata for the server is not updated (duplicati#4344).
@duplicatibot
Copy link

This issue has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/only-restores-empty-folders/17153/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants