Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the side menu fixed so it follows as you scroll #3022

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Pectojin
Copy link
Member

@Pectojin Pectojin commented Feb 8, 2018

We were discussing this on the forum and it's a super simply change, so here it goes.

I fixed the menu and then added padding to the content wrapper so that it's identical to how it looked previously, except now it scrolls :)

Only full sized settings were changed. It didn't seem to have any impact on the mobile layout.

@duplicatibot
Copy link

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/main-menu-location/2404/7

@kenkendk
Copy link
Member

kenkendk commented Feb 8, 2018

What are the odds... I just noticed that earlier today and commited just now:
39b429f

@Pectojin
Copy link
Member Author

Pectojin commented Feb 8, 2018

Hehe, they're pretty similar, I should have been quicker ;)

Does the margin 260px produce the same distance from the menu? I picked 300 for the padding because the menu is exactly 260 wide + 40 margin.

@kenkendk
Copy link
Member

kenkendk commented Feb 9, 2018

I think 300 is correct, because I forgot to factor in the padding, but used the margin to move it to the right instead.

@kenkendk kenkendk merged commit dba2a60 into duplicati:master Feb 9, 2018
@Pectojin Pectojin deleted the static_menu branch February 20, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants