Fix index files not being created for full dblock files #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the parallel upload changes a bug slipped in where a check was being made if the index volume writer exists before creating said index volume writer. Fixed by changing the test to check if the temporary index volume exists and then creating the writer for the index file.
|
Wow, thanks for the quick turnaround! 👍 |
|
No problem. It was a silly bug for me to have let slip through anyway. |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the parallel upload changes a bug slipped in where a check was
being made if the index volume writer exists before creating said index
volume writer to actually create the index file. Fixed by changing the
test to check if the temporary index volume exists and then creating
the writer for the index file.
Fixes #3703