Build RecoveryTool index in memory by default #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will plan to default to the in-memory index, but allow one to use the file-based index if the memory requirements are too high.
Performance is greatly improved if we can create the index in memory. We preserve the ability to create the index using files for recovery in low resource environments.
warwickmm
commented
Jan 24, 2020
| @@ -0,0 +1,246 @@ | |||
| // Copyright (C) 2015, The Duplicati Team | |||
There was a problem hiding this comment.
This is a rename of the original file-based Index class. The only modification was to move the call to SortFile from the Restore class to the end of the FileIndex.Run method.
|
The |
|
Great work! |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/timespan-to-rebuild-a-database/15654/22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
RecoveryToolso that the index is created in memory by default. This should yield a dramatic increase in performance. For low-resource situations, we allow one to use the original file-based index creation via the new--build-index-with-filesoption. We also modified theRecoveryTooltest to verify the behavior for both cases.The work to build the index in memory was done by @tfriedel (see revision 8848ad4 and pull request #4040).