Tardigrade: Correctly deploy binaries with the installer #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for all systems
|
There appear to be some merge conflicts. @TopperDEL, would you mind resolving them? I'm not very familiar with the installer code. We may need to wait for @kenkendk's input here. |
|
@warwickmm I've resolved the merge conflict. |
|
I would love to run the docker image on my server and test out the new tardigrade integration. Is there something I can do to help getting the PR over the finish line? |
warwickmm
reviewed
Jun 27, 2020
warwickmm
reviewed
Jun 27, 2020
…uplicati into tardigrade-installer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first try to deploy all the necessary binaries for Windows, Linux and MacOS with the installers.
Basically I've added all binaries as "Copy to output"-assets in the Tardigrade-Backend. From my understanding they would be copied into the "Installer-Zip-File". From there I remove all binaries that are not necessary for the current Platform.
On windows we have a 64 and a 32 bit version of the library, so I preload that DLL in the Tardigrade-Backend (only on windows).
I would be happy if someone who knows it could create an installer with it. I and others from Storj Labs could then test the different versions. I did and could not do any further testing with the scripts, but I've tried to do it exactly the same like the script already do it with SQLite and other assets, that get removed from platform-installers. The changes are quite straight-forward.
Thank you!