Create custom Exception for remote list verification failures #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would catch any Exception thrown by VerifyRemoteList and perform an auto-cleanup (if specified in the options). However, we should only perform the auto-cleanup if VerifyRemoteList detected an issue with the uploaded files. Otherwise, an unrelated exception can cause the database repair to be performed unnecessarily. In the case of a connection issue, this can leave the database in a corrupted state. This fixes duplicati#4516.
|
This pull request has been mentioned on Duplicati. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would catch any
Exceptionthrown byVerifyRemoteListand perform an auto-cleanup (if specified in the options). However, we should only perform the auto-cleanup ifVerifyRemoteListdetected an issue with the uploaded files. Otherwise, an unrelated exception can cause the database repair to be performed unnecessarily. In the case of a connection issue, the attempted repair (which requires listing the backend files) can leave the database in a corrupted (RepairInProgress) state.This fixes #4516.