Make Xamarin-based CocoaRunner the default on Mac #4802

dgileadi · 2022-08-03T19:55:13Z

This gets the tray icon running for me on macOS 12.5 by changing CocoaRunner to use Xamarin.Mac and making it the default on Mac instead of RumpsRunner.

Huge thanks to @tgorgdotcom for the help with getting this to build. The dependency changes are all thanks to him.

tgorgdotcom · 2022-08-04T15:10:30Z

This seems to be working on my end in macOS 12.3.

dgileadi · 2022-08-04T16:45:08Z

The AppVeyor build failed due to warnings found by BackendToolTests. I added code to get the actual exception from a TargetInvocationException which resulted in:

Backend result warning:2022-08-04 16:38:52 +00 - [Warning-Duplicati.Library.DynamicLoader.DynamicLoader`1-SoftError]: Failed to load process type Duplicati.Library.Backend.MicrosoftGroup assembly C:\projects\duplicati\Duplicati\UnitTest\bin\Debug\Duplicati.Library.Backend.OneDrive.dll, error message: The type initializer for 'Duplicati.Library.Backend.MicrosoftGraphBackend' threw an exception.
Backend result warning:2022-08-04 16:38:52 +00 - [Warning-Duplicati.Library.DynamicLoader.DynamicLoader`1-SoftError]: Failed to load process type Duplicati.Library.Backend.OneDriveV2 assembly C:\projects\duplicati\Duplicati\UnitTest\bin\Debug\Duplicati.Library.Backend.OneDrive.dll, error message: The type initializer for 'Duplicati.Library.Backend.MicrosoftGraphBackend' threw an exception.
Backend result warning:2022-08-04 16:38:52 +00 - [Warning-Duplicati.Library.DynamicLoader.DynamicLoader`1-SoftError]: Failed to load process type Duplicati.Library.Backend.SharePointV2 assembly C:\projects\duplicati\Duplicati\UnitTest\bin\Debug\Duplicati.Library.Backend.OneDrive.dll, error message: The type initializer for 'Duplicati.Library.Backend.MicrosoftGraphBackend' threw an exception.

A local unit test run didn't fail. There are no other details about why MicrosoftGraphBackend threw an exception. I'm not sure where to go from here. Could someone on a Windows system perhaps try this branch out to try to help track down the issue?

tgorgdotcom · 2022-08-08T21:34:51Z

Rewriting and reposting because I didn't properly explain this:

I'm trying this on my Windows laptop, and I get the following exception when I run the debug, then try to access the server (http://localhost:8200/):

FileNotFoundException: Could not load file or assembly 'System.Net.Http, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

This is being triggered from the Duplicati\Library\Backend\OneDrive\MicrosoftGroup.cs, in the MicrosoftGroup object's initializer. Seems to be related to your errors above. If I continue the code execution, the same exception occurs in Duplicati\Library\Backend\OneDrive\OneDriveV2.cs. And if I continue that, another exception occurs in Duplicati\Library\Backend\OneDrive\SharePointV2.cs.

System.Net is indeed used in Duplicati\Library\Backend\OneDrive\MicrosoftGraphBackend.cs, in which the aforementioned code inherits, but I'm not sure why it would be throwing an error.

tgorgdotcom · 2022-08-10T22:46:44Z

Just to be sure, I pulled a fresh copy of the original repository and I getting the same errors. I'm thinking maybe we can ignore these then? Any thoughts from the maintainers?

m-m-m-m-m-m-m-m-m-m-m-m · 2022-09-04T10:10:53Z

This seems to be working on my end in macOS 12.3.

How can I get the application?

m-m-m-m-m-m-m-m-m-m-m-m · 2022-09-04T10:28:18Z

This gets the tray icon running for me on macOS 12.5 by changing CocoaRunner to use Xamarin.Mac and making it the default on Mac instead of RumpsRunner.

Huge thanks to @tgorgdotcom for the help with getting this to build. The dependency changes are all thanks to him.

@dgileadi I would like to try your solution, but I dont understand how to build and test it. Could you help me?

dgileadi · 2022-11-02T16:17:09Z

@dgileadi I would like to try your solution, but I dont understand how to build and test it. Could you help me?

I'm no expert in building Duplicati since I'm quite new to its code, so I'm not much help. Basically what you'd want to do is get a local copy of my cocoa-mac branch and then build it using Visual Studio for Mac. That may sound simple (or not!) but it's the details and troubleshooting that I wouldn't be much help with.

duplicatibot · 2022-12-29T00:26:31Z

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/supportability-of-newer-macos/15515/2

dgileadi · 2023-02-28T21:31:55Z

Okay, for future reference I built Duplicati locally. Here's what I did:

Ran ./make.sh to make duplicati. This creates a file named Installer/Makefile/duplicati.tar.gz
Manually extract that file which creates a directory tree starting with usr
Re-zip all the files under the extracted usr/lib/duplicati into a new .zip file which I called Duplicati-osxtray.zip
Cd into Installer/OSX
Edit make-dmg.sh in that directory to add a new line 203: hdiutil resize -size 128m "$WC_DMG" (just before the comment that says "# Make a mount point and mount the new dmg"). This fixes issues where files failed to copy because there was no more room on the .dmg.
Run ./make-dmg.sh ../Duplicati-osxtray.zip (where the argument is the path where I put my .zip file)
Enter my local machine's password to make sudo happy

After the above finishes a new file named Duplicati.dmg will exist inside Installer/OSX, and you can use that to install Duplicati. Note that Gatekeeper may give you trouble running it since it is unsigned. Right-clicking on the newly installed Duplicati.app and choosing Open worked for me.

duplicatibot · 2023-02-28T22:41:31Z

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/is-duplicati-kind-of-abandoned/15791/2

dgileadi · 2023-03-01T21:05:19Z

I've made a test release for anyone wanting to try this out.

duplicatibot · 2023-03-01T21:18:41Z

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/duplicati-not-starting-on-macos-monterey-12-3-on-m1/14096/19

bob787 · 2023-03-02T16:00:23Z

Happy day! Thank you @dgileadi!

It works just like the pre-Monterey Duplicati versions. I will keep it on my bench and let it run a simple backup and restore loop for a few days to see if issues arise.

gpatel-fr · 2023-03-04T20:41:28Z

Hello @dgileadi

I don't understand why your PR has changes in the AWS and IDrive backends - what is the relation to the TrayIcon ?

dgileadi · 2023-03-04T21:20:25Z

Hello @dgileadi

I don't understand why your PR has changes in the AWS and IDrive backends - what is the relation to the TrayIcon ?

The changes were necessary to get the project to build on macOS. Visual Studio on macOS originally generated a much messier set of changes but @tgorgdotcom helped make them more manageable.

gpatel-fr · 2023-03-04T22:32:53Z

Hmm.. is this generated by the quirks of VS, or is it necessary for some mysterious reason. I have generated a build of your PR in my test repo, I think that I will generate another while removing these curious refs in IDrive and AWS backends to see how it goes.

gpatel-fr · 2023-03-05T18:00:09Z

@dgileadi
I have actually done 2 builds, one without the backends:
https://github.com/gpatel-fr/testdupl/actions/runs/4336388168

and one without the backends AND bouncycastle reference:
https://github.com/gpatel-fr/testdupl/actions/runs/4336935079
never mind the test failure, it's obviously unrelated.

I have found that BouncyCastle lib was explicitly removed from Duplicati in 2021, so adding it back if it's not necessary would have 2 problems: adding some size to all downloads, and possibly involve license problem - so-called 'liberal' licenses involve publicity in their terms and if it's added to a project, there should be an aknowledgement somewhere - that could have been removed in 2021.
I have no idea why this ref has been added by your dev environment; either there is a real dependency on the Xamarin based CocaRunner on this lib (in this case the price has to be paid), or there is somewhere in the Duplicati internals a not so obvious ref to this library that is picked up ("helpfully") by the dev environment to add it back to the project. In this case it's not good.

Anyway, test of these Mac binaries would be very interesting, I don't know anything about dependencies on OSX, if there could be a library staying from a previous install that is picked up by a new install (in this case the binary could work on a already installed computer, but not on a 'new' one). If it is the case, well, a freshly installed computer would be the best to test if this works as intended.

dgileadi · 2023-03-06T16:23:09Z

Hi @gpatel-fr, for the BouncyCastle dependency see the discussion in issue #4668 (search for BouncyCastle in the comments) and the discussion in PR #4800. It appears the dependency is needed when Xamarin AppKit is used.

I tried both your builds and weirdly neither one showed a menu bar icon for me. The Activity Monitor app showed Duplicati briefly starting and then quitting. Maybe someone else can try them out?

gpatel-fr · 2023-03-06T16:55:44Z

All right, then. This build was generated with the original PR:

https://github.com/gpatel-fr/testdupl/actions/runs/4332749394

From the log, it was compiled on a OSX 12.6 runner. Is the Mac binary in this build working as intended ? If yes, I'll take care of digging the old ref to BouncyCastle in the doc files and adding it back to satisfy the software license advertising clause.

dgileadi · 2023-03-06T17:05:56Z

@gpatel-fr this latest build has the same behavior for me as the other two builds—it briefly appears in Activity Monitor and then quits again, and never shows a menu bar icon. I'm not sure how to check what the trouble is—does anyone know where any logs might be found?

gpatel-fr · 2023-03-06T17:20:39Z

This is very annoying to say the least, since this build command file has been ripped out of the normal build file - this particular file runs only on the original Duplicati author's computer.
I will have to double check that I did not leave out something necessary.
Maybe running the command as mono Duplicati.Gui.TrayIcon.exe in a command terminal ? That's what I would try under Windows. Under Windows there is ProcessMonitor, I don't know what's the equivalent could be under OSX. Internet search suggests a tool called 'Glances'.

Edit: obviously something I left out is the notarising of the applicatlon. But it should be the same for your build I guess ? And other people have tested your build and it worked on their computer. What's the version of your computer and dev tools ?

gpatel-fr · 2023-03-07T12:56:56Z

I think I have found the problem. Could you please try this build:

https://github.com/gpatel-fr/dupltest/actions/runs/4354235641

dgileadi · 2023-03-07T14:54:06Z

I think I have found the problem. Could you please try this build:

https://github.com/gpatel-fr/dupltest/actions/runs/4354235641

That one works for me. Nice job, whatever you did!

Edit: as for notarizing, you're right that neither your nor my build are notarized. As such you need to go through a dance of right-clicking on the application and choosing open a couple times before it'll let you run it. For a real distributable build it'd be really nice to get the GitHub actions nicely notarizing the Mac builds at some point.

gpatel-fr · 2023-03-07T15:23:02Z

What I did is to look closely at the official build (the one running on the original author's computer), your build (based on the Linux build actually), and the build in the automatic build I am trying to setup on Github. I realized then that the installer build on Github is very similar to the other builds, except an additional parameter enabling Gtk. In all probability Gtk could never has been be useful to Duplicati for another thing than the Tray Icon, while there was absolutely no use for it in the automatic build on Github, since there is no graphical user interface for the runners.
I had then the suspicion that the inclusion of Gtk in the Github test builds was but a fossil of another epoch, something that was no use whatsoever as the Tray Icon can't be tested in a Github runner, the builds on Github could never has been actually run on an actual computer, or not since quite some time, but it had never become apparent since nobody had until now tried to create an installer based on them.

About the notarization, the secrets are on the original author computer, not on Github. My current priority is to get a new release that works, at the moment the actual notarized build will still come from this computer by the original author. That's awkward but there are more urgent problems IMO.

My immediate plan is to release a binary build on the forum with all the planned changes included this PR and asking for a feedback given the character of this release. Hopefully I'll get a test for each of the platforms at least, if nothing obviously bad is reported it will become a canary ASAP.

bob787 · 2023-03-07T22:57:27Z

Happy to test the Mac versions. I will continue to monitor this thread

gpatel-fr · 2023-03-20T09:27:05Z

@bob787
I have pushed a tentative binary build -> https://forum.duplicati.com/t/preview-of-security-and-bugfix-release-canary-105/15925

duplicatibot · 2023-03-23T23:06:37Z

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/preview-of-security-and-bugfix-release-canary-105/15925/32

earthsound · 2023-04-19T18:24:49Z

With version 2.0.6.105, as mentioned in the forum, I'm seeing this error when running mono Duplicati.GUI.TrayIcon.exe --toolkit=cocoa:

2023-04-19 13:02:55.590 mono-sgen64[2793:41223] Could not find `appindicator-sharp` referenced by assembly `Duplicati.GUI.TrayIcon, Version=2.0.6.105, Culture=neutral, PublicKeyToken=null`.
Unexpected error: System.IO.FileNotFoundException: Could not load the file 'appindicator-sharp'.
File name: 'appindicator-sharp'
  at System.AppDomain.Load (System.Reflection.AssemblyName assemblyRef, System.Security.Policy.Evidence assemblySecurity) [0x0007a] in <b814b509d4ad406fb40c6c93e38929e7>:0 
  at (wrapper remoting-invoke-with-check) System.AppDomain.Load(System.Reflection.AssemblyName,System.Security.Policy.Evidence)
  at System.AppDomain.Load (System.Reflection.AssemblyName assemblyRef) [0x00000] in <b814b509d4ad406fb40c6c93e38929e7>:0 
  at (wrapper remoting-invoke-with-check) System.AppDomain.Load(System.Reflection.AssemblyName)
  at System.Reflection.Assembly.Load (System.Reflection.AssemblyName assemblyRef) [0x00005] in <b814b509d4ad406fb40c6c93e38929e7>:0 
  at ObjCRuntime.Runtime.CollectReferencedAssemblies (System.Collections.Generic.List`1[T] assemblies, System.Reflection.Assembly assembly) [0x000a0] in <e4522fda950a42e1a61f97b36f071593>:0 
  at ObjCRuntime.Runtime.RegisterEntryAssembly (System.Reflection.Assembly entry_assembly) [0x0002f] in <e4522fda950a42e1a61f97b36f071593>:0 
  at ObjCRuntime.Runtime.RegisterAssemblies () [0x00006] in <e4522fda950a42e1a61f97b36f071593>:0 
  at AppKit.NSApplication.Init () [0x00022] in <e4522fda950a42e1a61f97b36f071593>:0 
  at Duplicati.GUI.TrayIcon.CocoaRunner.Init (System.String[] args) [0x00001] in <e98c34ad898147e8a9669bdece28c5ac>:0 
  at Duplicati.GUI.TrayIcon.Program.StartTray (System.String[] _args, System.Collections.Generic.Dictionary`2[TKey,TValue] options, System.String toolkit, Duplicati.GUI.TrayIcon.HostedInstanceKeeper hosted, System.String password, System.Boolean saltedpassword) [0x000f9] in <e98c34ad898147e8a9669bdece28c5ac>:0

Would you prefer I open an issue referencing this?

dgileadi added 2 commits August 3, 2022 12:35

Make Xamarin-based CocoaRunner the default on Mac

6f0ae31

Clean up csproj items

a8ee4c4

dgileadi mentioned this pull request Aug 3, 2022

"Duplicati needs to be updated" warning on upgrade to MacOS Monterrey 12.1 #4668

Open

2 tasks

tgorgdotcom mentioned this pull request Aug 3, 2022

Remove python 2 dependencies #4690

Closed

dgileadi added 2 commits August 3, 2022 14:46

Work on cross-platform build

160a083

Use conditional compilation for TryGetXamarinMac

a17bd1b

Get actual exception when logging errors

88480f2

gpatel-fr mentioned this pull request Sep 7, 2022

MacOS Monterey 12.5.1 - Python 2.7 Not Found #4816

Closed

Merge branch 'master' into cocoa-mac

3538507

Use template images, which work in dark menu bars

9763305

gpatel-fr merged commit 9302aab into duplicati:master Mar 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Xamarin-based CocoaRunner the default on Mac #4802

Make Xamarin-based CocoaRunner the default on Mac #4802

dgileadi commented Aug 3, 2022

tgorgdotcom commented Aug 4, 2022

dgileadi commented Aug 4, 2022

tgorgdotcom commented Aug 8, 2022

tgorgdotcom commented Aug 10, 2022

m-m-m-m-m-m-m-m-m-m-m-m commented Sep 4, 2022 •

edited

m-m-m-m-m-m-m-m-m-m-m-m commented Sep 4, 2022

dgileadi commented Nov 2, 2022

duplicatibot commented Dec 29, 2022

dgileadi commented Feb 28, 2023

duplicatibot commented Feb 28, 2023

dgileadi commented Mar 1, 2023

duplicatibot commented Mar 1, 2023

bob787 commented Mar 2, 2023

gpatel-fr commented Mar 4, 2023

dgileadi commented Mar 4, 2023

gpatel-fr commented Mar 4, 2023

gpatel-fr commented Mar 5, 2023

dgileadi commented Mar 6, 2023

gpatel-fr commented Mar 6, 2023

dgileadi commented Mar 6, 2023

gpatel-fr commented Mar 6, 2023 •

edited

gpatel-fr commented Mar 7, 2023

dgileadi commented Mar 7, 2023 •

edited

gpatel-fr commented Mar 7, 2023

bob787 commented Mar 7, 2023

gpatel-fr commented Mar 20, 2023

duplicatibot commented Mar 23, 2023

earthsound commented Apr 19, 2023

Make Xamarin-based CocoaRunner the default on Mac #4802

Make Xamarin-based CocoaRunner the default on Mac #4802

Conversation

dgileadi commented Aug 3, 2022

tgorgdotcom commented Aug 4, 2022

dgileadi commented Aug 4, 2022

tgorgdotcom commented Aug 8, 2022

tgorgdotcom commented Aug 10, 2022

m-m-m-m-m-m-m-m-m-m-m-m commented Sep 4, 2022 • edited

m-m-m-m-m-m-m-m-m-m-m-m commented Sep 4, 2022

dgileadi commented Nov 2, 2022

duplicatibot commented Dec 29, 2022

dgileadi commented Feb 28, 2023

duplicatibot commented Feb 28, 2023

dgileadi commented Mar 1, 2023

duplicatibot commented Mar 1, 2023

bob787 commented Mar 2, 2023

gpatel-fr commented Mar 4, 2023

dgileadi commented Mar 4, 2023

gpatel-fr commented Mar 4, 2023

gpatel-fr commented Mar 5, 2023

dgileadi commented Mar 6, 2023

gpatel-fr commented Mar 6, 2023

dgileadi commented Mar 6, 2023

gpatel-fr commented Mar 6, 2023 • edited

gpatel-fr commented Mar 7, 2023

dgileadi commented Mar 7, 2023 • edited

gpatel-fr commented Mar 7, 2023

bob787 commented Mar 7, 2023

gpatel-fr commented Mar 20, 2023

duplicatibot commented Mar 23, 2023

earthsound commented Apr 19, 2023

m-m-m-m-m-m-m-m-m-m-m-m commented Sep 4, 2022 •

edited

gpatel-fr commented Mar 6, 2023 •

edited

dgileadi commented Mar 7, 2023 •

edited