Catch RetiredException in BackupHandler to avoid StopNow race condition #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. And yes, the retired exception is the only way to reliably detect a closed channel without races. |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/how-to-recover-from-aborted-stuck-crashed-backup-run/17818/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4980
There seems to be no way to reliably check whether the channel is retired, so I handle the
RetiredExceptionwhich should fix the random test failures forStopNowthat occur sometimes (most recently in this build). The CoCoL examples also uses the exception to handle retired channels.