forked from pharo-project/pharo
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ReleaseTest.class.st
381 lines (304 loc) · 12.1 KB
/
ReleaseTest.class.st
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
"
I contain tests that validate the integrity of the system.
"
Class {
#name : #ReleaseTest,
#superclass : #AbstractEnvironmentTestCase,
#category : #'ReleaseTests-Release'
}
{ #category : #accessing }
ReleaseTest class >> actualProcesses [
^ Process allSubInstances reject: [ :each | each isTerminated ]
]
{ #category : #accessing }
ReleaseTest class >> defaultTimeLimit [
^ 1 minute
]
{ #category : #accessing }
ReleaseTest class >> knownProcesses [
"Return a dynamic list of know processes"
"(self actualProcesses difference: self knownProcesses) do: [ :each | each suspend; terminate ]."
^ {
Processor activeProcess.
InputEventFetcher default fetcherProcess.
WeakArray runningFinalizationProcess.
Processor backgroundProcess.
SmalltalkImage current lowSpaceWatcherProcess.
UIManager default uiProcess.
Delay schedulingProcess } asSet
]
{ #category : #accessing }
ReleaseTest >> actualProcesses [
^ self class actualProcesses
]
{ #category : #helpers }
ReleaseTest >> assertValidLintRule: aLintRule [
self assertValidLintRule: aLintRule withExceptions: {}
]
{ #category : #helpers }
ReleaseTest >> assertValidLintRule: aLintRule withExceptions: someNames [
| runner results |
runner := ReSmalllintChecker new.
runner
rule: {aLintRule};
environment: RBBrowserEnvironment default;
run.
results := (runner criticsOf: aLintRule) reject: [ :critique | someNames includes: critique entity name ].
self
assert: results isEmpty
description: [ String
streamContents: [ :s |
s
<< aLintRule rationale;
lf;
<< 'Violations: ';
lf.
results
do: [ :e |
s
<< '- ';
print: e entity ]
separatedBy: [ s lf ] ] ]
]
{ #category : #helpers }
ReleaseTest >> hasStartUpOrShutDownMethod: aClass [
| keySelectors |
keySelectors := #(#startUp #startUp: #shutDown #shutDown:).
^ (aClass selectors includesAny: keySelectors)
or: [ aClass class selectors includesAny: keySelectors ]
]
{ #category : #accessing }
ReleaseTest >> knownProcesses [
^ self class knownProcesses
]
{ #category : #tests }
ReleaseTest >> testAllClassPoolBindingAreClassVariables [
| wrong |
wrong := OrderedCollection new.
testingEnvironment allClasses do: [ :class | wrong addAll: (class classVariables reject: [ :each | each isKindOf: ClassVariable ]) ].
self assertEmpty: wrong
]
{ #category : #tests }
ReleaseTest >> testAllGlobalBindingAreGlobalVariables [
| wrong |
wrong := testingEnvironment associations reject: [ :each | each isKindOf: GlobalVariable ].
self assertEmpty: wrong
]
{ #category : #tests }
ReleaseTest >> testExplicitRequirementMethodsShouldBeImplementedInTheirUsers [
"If a class is using a trait with an explicit requirement method, this class should implement the method"
self assertValidLintRule: ReExplicitRequirementMethodsRule new
]
{ #category : #tests }
ReleaseTest >> testInstalledMethodsWithIncorrectTrailerKind [
| incorrectMethods |
incorrectMethods := SystemNavigation new installedMethodsWithIncorrectTrailerKind.
self
assert: incorrectMethods isEmpty
description: [ String streamContents: [ :s|
s
nextPutAll: 'Found methods with incorrect trailer kind: ';
print: incorrectMethods ]].
]
{ #category : #tests }
ReleaseTest >> testInstanceSideMethodsWithNilKeyInLastLiteral [
| instanceSideMethodsWithNilKeyInLastLiteral |
instanceSideMethodsWithNilKeyInLastLiteral := SystemNavigation new instanceSideMethodsWithNilKeyInLastLiteral.
self
assert: instanceSideMethodsWithNilKeyInLastLiteral isEmpty
description: [ String streamContents: [ :s|
s
nextPutAll: 'Found methods with nil as last literal: ';
print: instanceSideMethodsWithNilKeyInLastLiteral ]].
]
{ #category : #tests }
ReleaseTest >> testKeyClassesArePresentInStartupList [
| keyClasses registeredHandlers |
keyClasses := #(#Delay #ProcessorScheduler #Stdio #OSPlatform #UUIDGenerator #DiskStore #WeakArray #BasicCommandLineHandler).
registeredHandlers := SessionManager default startupList
collect: #handledId.
keyClasses do: [ :className |
self assert: (registeredHandlers includes: className).
self assert: (self hasStartUpOrShutDownMethod: (testingEnvironment at: className)) ].
self assert: (registeredHandlers includes: #UIManagerSessionHandler).
]
{ #category : #tests }
ReleaseTest >> testLayoutIntegrity [
SystemNavigation default allClassesDo: [ :class |
class instanceSide classLayout checkIntegrity.
class classSide classLayout checkIntegrity ]
]
{ #category : #tests }
ReleaseTest >> testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits [
"If a class is using a trait with an explicit requirement method, this class should implement the method"
self assertValidLintRule: ReLocalMethodsSameThanTraitRule new withExceptions: #(RBSmalllintTestLocalMethodsSameThanTraitObject).
]
{ #category : #tests }
ReleaseTest >> testManifestNamesAccordingToPackageNames [
"Make sure package name and manifest name are in synch"
|manifestClasses actualManifestNames expectedManifestNames |
manifestClasses := self class environment allClasses select: [:each | each isManifest ].
actualManifestNames := (manifestClasses collect: [:each | each name ]) sorted.
expectedManifestNames := manifestClasses
collect: [:each | TheManifestBuilder manifestClassNameFor: each package name ].
self assert: actualManifestNames equals: expectedManifestNames
]
{ #category : #tests }
ReleaseTest >> testMethodsWithUnboundGlobals [
| methodsWithUnboundGlobals |
"Ensure the environment is clean"
3 timesRepeat: [ Smalltalk garbageCollect ].
Smalltalk cleanOutUndeclared.
methodsWithUnboundGlobals := SystemNavigation new methodsWithUnboundGlobals.
self
assert: methodsWithUnboundGlobals isEmpty
description: [ String streamContents: [ :s |
s
nextPutAll: 'Found methods with unbound globals: ';
print: methodsWithUnboundGlobals ]]
]
{ #category : #tests }
ReleaseTest >> testNoEmptyPackages [
"Test that we have no empty packages left"
| violating |
violating := RPackageOrganizer default packages select: #isEmpty.
self assertEmpty: violating
]
{ #category : #tests }
ReleaseTest >> testNoNilAssignmentInInitializeMethod [
self assertValidLintRule: ReNoNilAssignationInInitializeRule new
]
{ #category : #tests }
ReleaseTest >> testObsoleteClasses [
| obsoleteClasses |
Smalltalk fixObsoleteReferences.
Smalltalk garbageCollect.
obsoleteClasses := SystemNavigation new obsoleteClasses
select: [ :each | each isAnonymous not ].
self
assert: obsoleteClasses isEmpty
description: [
String streamContents: [ :s|
s
nextPutAll: 'Obsolete classes remaining: ';
print: obsoleteClasses ]]
]
{ #category : #tests }
ReleaseTest >> testPharoVersionFileExists [
"Test there is a pharo.version file next to this image containing the short version of this pharo image.
This file is required by the Pharo launcher to correctly detect the Pharo version we are running on."
| pharoVersionFile |
pharoVersionFile := FileLocator imageDirectory / 'pharo.version'.
self assert: pharoVersionFile exists.
self
assert: pharoVersionFile readStream contents trimBoth
equals: SystemVersion current major asString, SystemVersion current minor asString
]
{ #category : #'tests - packages - manifests' }
ReleaseTest >> testProperManifestClasses [
|manifests|
manifests := self class environment allClasses select: [:each | each isManifest ].
self assert: (manifests allSatisfy: [:each | each inheritsFrom: PackageManifest ]).
self assert: (manifests allSatisfy: [:each | each name beginsWith: 'Manifest' ]).
]
{ #category : #'tests - rpackage' }
ReleaseTest >> testRPackageOrganizer [
"Ensure other tests temporary created organizers are collected"
3 timesRepeat: [ Smalltalk garbageCollect ].
"Now check :)"
self
assert: RPackageOrganizer allInstances size = 1
description: 'There are multiple (', RPackageOrganizer allInstances size asString, ') instances of RPackageOrganizer'.
self
assert: RPackageOrganizer allInstances first == RPackageOrganizer default
description: 'The default package organizer is the not the only instance of RPackageOrganizer'.
]
{ #category : #tests }
ReleaseTest >> testShouldFileLocatorBeBeforeSystemSettingsPersistenceInStartupList [
"This test documents issue https://pharo.manuscript.com/f/cases/17721"
| startupList settingsIndex |
startupList := (SessionManager default startupList collect: #handledId).
settingsIndex := startupList indexOf: #SystemSettingsPersistence.
settingsIndex > 0
ifTrue: [ self should: [ (startupList indexOf: #FileLocator) < (startupList indexOf: #SystemSettingsPersistence) ] ]
]
{ #category : #tests }
ReleaseTest >> testShouldWorldMorphBeAfterFontClassesInStartupList [
"This test documents issue https://pharo.manuscript.com/f/cases/17834"
"The Startup of he WorldMorph is now done in the UIManagerHandler"
| startupList |
startupList := (SessionManager default startupList collect: #handledId).
#(StrikeFont LogicalFont FreeTypeSettings FreeTypeCache FT2Handle)
do: [ :fontClass |
self should: [ (startupList indexOf: #UIManagerSessionHandler) > (startupList indexOf: #SystemSettingsPersistence) ] ]
]
{ #category : #tests }
ReleaseTest >> testTestCasesEndsWithTestOrTestCase [
self assertValidLintRule: ReTestClassNameShouldEndWithTestRule new
]
{ #category : #'tests - rpackage' }
ReleaseTest >> testThatAllMethodsArePackaged [
| classes instanceMethods classMethods allMethods methodsWithoutPackageInfo |
classes := Smalltalk allClassesAndTraits.
instanceMethods := classes flatCollect: #methods.
classMethods := classes flatCollect: [ :class | class classSide methods ].
allMethods := instanceMethods , classMethods.
methodsWithoutPackageInfo := allMethods select: [ :method | method package isNil ].
self assertEmpty: methodsWithoutPackageInfo
]
{ #category : #tests }
ReleaseTest >> testUndeclared [
| undeclaredBindings |
Smalltalk cleanOutUndeclared.
undeclaredBindings := Undeclared keys reject: [:each |
each includesSubstring: 'undeclaredStub' caseSensitive: false].
self
assert: undeclaredBindings isEmpty
description: (String streamContents: [ :s|
s
nextPutAll: 'Found undeclared references: ';
print: undeclaredBindings ])
]
{ #category : #tests }
ReleaseTest >> testUnknownProcesses [
"Make sure that there are no other processes running except the known processes"
| unknownProcesses |
unknownProcesses := self actualProcesses difference: self knownProcesses.
self
assert: unknownProcesses size <=2
description: (String streamContents: [ :out |
out << 'Found unknown processes: '.
unknownProcesses
do: [ :each | out print: each ]
separatedBy: [ out << ', ' ] ])
]
{ #category : #'tests - rpackage' }
ReleaseTest >> testUnpackagedClasses [
| unpackagedClasses |
unpackagedClasses := Smalltalk allClassesAndTraits select: [:each |
(RPackageOrganizer default packageOf: each) packageName = RPackage defaultPackageName ].
self
assert: unpackagedClasses isEmpty
description: (String streamContents: [ :s|
s nextPutAll: 'Found the following unpackaged classes: '.
unpackagedClasses
do: [ :cls| s tab print: cls ]
separatedBy: [ s cr ]])
]
{ #category : #'tests - rpackage' }
ReleaseTest >> testUnpackagedPackageShouldBeEmpty [
| unpackagePackage |
unpackagePackage := RPackageOrganizer default packageNamed: RPackage defaultPackageName.
"The unpackage package should not have any defined class or extended classes"
self assertEmpty: unpackagePackage classes
]
{ #category : #tests }
ReleaseTest >> testWorldMenuHasHelpForAllEntries [
"In this test we check that at least every terminal menu entry of the world menu has an help."
| menuElements |
menuElements := WorldState new menuBuilder itemList.
"Here we have the roots of the menu. We want the terminal menu entries."
[ menuElements allSatisfy: [ :each | each itemList isNil ] ]
whileFalse: [ menuElements := menuElements inject: OrderedCollection new into: [ :coll :each | each itemList ifNil: [ coll add: each ] ifNotNil: [ :items | coll addAll: items ]. coll ] ].
menuElements collect: #spec thenDo: [ :item | self assert: item help isNotNil description: item label , ' menu entry in world menu should have an help.' ]
]