Array Merge Errors

[koconder]

Possible fix suppressing errors for #121

[duracelltomi]

Thanks for the addition!

I am not sure whether suppressing the error would actually fix this as there must be a reason for the wrong variable type.

According to the doc, get_user_meta() will return the value of the meta_value field or an empty string if the value does not exists yet. This empty value is checked just after the get_user_meta() call. If empty value is returned, a default array value is passed to $gtm4wp_user_notices_dismisses. I wonder if there is any case when this fallback variable is not yet initialized while gtm4wp_show_warning() is executing?

My second guess is whether there might be a state when unserialize() is not returning an array type result? I do not see yet how this could happen besides directly manipulating DB fields but perhaps if ( false === $gtm4wp_user_notices_dismisses ) { after unserialize() could be changed to a type check rather then checking the boolean value false.

What do you think?

[koconder]

@duracelltomi i might leave this with you then, outside of my understanding of the original code

[duracelltomi]

No problem, I will take care of this