Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses incompatibilities with mysql 8.x #151

Merged
merged 1 commit into from Dec 3, 2021

Conversation

dbernstein
Copy link
Member

Addresses incompatibilities with mysql 8.x


JIRA Ticket:https://duracloud.atlassian.net/browse/DURACLOUD-1298

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this Pull Request do?

Makes the storage report API compatible with mysql 8. This change should be backwards compatible.

How should this be tested?

Deploy against mysql 8.x
Navigate to a space in duradmin.
Verify that the storage reports are visible and no errors are displayed.

A description of what steps someone could take to:
To reproduce the error, run without this change against mysql 8 - the duradmin UI will report a failure to display the time series.

Interested parties

Tag (@ mention) interested parties or, if unsure, @duracloud/committers

Copy link
Member

@bbranan bbranan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

@dbernstein dbernstein merged commit 5cc240a into duracloud:develop Dec 3, 2021
@dbernstein dbernstein deleted the mysql8-upgrade branch December 3, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants