DURACLOUD-1049: Updates jQueryFileTree to version 2.1.5 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
approved these changes
Nov 18, 2022
dbernstein
reviewed
Nov 18, 2022
There was a problem hiding this comment.
@nwoodward : I validated that everything still works as before however I was not able to confirm the fix. I'm assuming you tried it on your side and saw that the issue was fixed?
|
I don't personally have a Windows machine with networked drives, but we do have a DuraCloud user with those conditions. She confirmed that with this PR included in the Sync Tool code those networked drives became visible to her. This bug was reported in the jQuery File Tree repository here: jqueryfiletree/jqueryfiletree#21. I did some testing myself to make sure that this newer version of File Tree doesn't impact any regular Sync Tool operations, and that's what I was hoping you could confirm before accepting the PR. |
nwoodward
added a commit
to TexasDigitalLibrary/duracloud
that referenced
this pull request
Jan 9, 2023
This reverts commit 154a003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Javascript dependency for displaying the local filesystem in the SyncTool UI. The most recent version of jQueryFileTree includes a fix for a bug where networked drives don't appear in the directory list if the user is on Windows.
JIRA Ticket: https://duracloud.atlassian.net/browse/DURACLOUD-1049
Interested parties
@duracloud/committers