put_object_stream sync implementation always fails for small files

[jccallu-genomicsplc]

Describe the bug

This bug is still present in the current master branch in s3/src/bucket.rs:1193 and in v0.33 for the sync implementation.

At this line the function should always return a Result and not continue in case of success. Currently this means we will try to read more from the reader, and return an error because it is exhausted. This makes the function always fail for small objects.

To Reproduce

This is a systematic error with put_object_stream sync implementation. A unit test should exist to cover this

Expected behavior

put_object_stream should always return the actual result of its upload

Environment

• Rust version: 1.69
• lib version 0.33

[dgrr]

When

[ribeaud]

Is this project dead or what? Why does this very useful PR not get merged?