Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo: Move tokio-stream create behind the with-tokio feature #248

Merged
merged 1 commit into from
Feb 12, 2022
Merged

cargo: Move tokio-stream create behind the with-tokio feature #248

merged 1 commit into from
Feb 12, 2022

Conversation

MarijnS95
Copy link
Contributor

tokio-stream has a dependency on tokio and is only used within the request module, which depends on the with-tokio feature. As such, in order to completely prevent tokio from appearing in the crate graph, this crate must be marked optional and enabled when with-tokio is requested, omitted otherwise.

Also includes two drive-by typo-fixes in the features section of the readme.

@MarijnS95
cargo: Move tokio-stream create behind the with-tokio feature
dea5c8a 
`tokio-stream` has a dependency on `tokio` and is only used within the
`request` module, which depends on the `with-tokio` feature.  As such,
in order to completely prevent `tokio` from appearing in the crate
graph, this crate must be marked optional and enabled when `with-tokio`
is requested, omitted otherwise.

Also includes two drive-by typo-fixes in the features section of the
readme.
@MarijnS95 MarijnS95 mentioned this pull request Jan 28, 2022
Open
38 tasks
@durch durch changed the base branch from master to develop February 12, 2022 21:07
@durch
Copy link
Owner

durch commented Feb 12, 2022

@MarijnS95 thanks for this, will be included in the next release

@durch durch merged commit c1a174d into durch:develop Feb 12, 2022
@MarijnS95 MarijnS95 deleted the no-tokio branch February 12, 2022 21:10
durch added a commit that referenced this pull request Feb 12, 2022
@durch
Fixup #248
10cf754
durch added a commit that referenced this pull request Feb 12, 2022
@durch @MarijnS95
s3 0.29.0 (#253)
d1f231a 
* cargo: Move `tokio-stream` create behind the `with-tokio` feature (#248)

`tokio-stream` has a dependency on `tokio` and is only used within the
`request` module, which depends on the `with-tokio` feature.  As such,
in order to completely prevent `tokio` from appearing in the crate
graph, this crate must be marked optional and enabled when `with-tokio`
is requested, omitted otherwise.

Also includes two drive-by typo-fixes in the features section of the
readme.

* Fixup #248

* Migrate from `chrono` to `time` to solve RUSTSEC-2020-0159 (#250)

`chrono` still hasn't found a solution to [RUSTSEC-2020-0159] whereas
`time` already solved its vulnerability to [RUSTSEC-2020-0071] by hiding
the affected functionality behind a cfg flag (not to be confused with a
`feature`, such `cfg`s can only be enabled through `RUSTFLAGS`).  At the
same time `chrono` is a superset of `time` even though this crate hardly
uses any functionality of it: only UTC time is needed which does not
suffer from aforementioned local time vulnerabilities.

[RUSTSEC-2020-0071]: https://rustsec.org/advisories/RUSTSEC-2020-0071
[RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159

Co-authored-by: Drazen Urch <drazen@urch.eu>

* Update Makefile

* Closes #245

* Bump aws-region

* s3 0.29.0

Co-authored-by: Marijn Suijten <marijns95@gmail.com>
durch added a commit that referenced this pull request Mar 4, 2022
@castaneai @durch @MarijnS95
Providing more detailed error when the put API fails (#257)
d7f3ee7 
* s3 0.29.0 (#253)

* cargo: Move `tokio-stream` create behind the `with-tokio` feature (#248)

`tokio-stream` has a dependency on `tokio` and is only used within the
`request` module, which depends on the `with-tokio` feature.  As such,
in order to completely prevent `tokio` from appearing in the crate
graph, this crate must be marked optional and enabled when `with-tokio`
is requested, omitted otherwise.

Also includes two drive-by typo-fixes in the features section of the
readme.

* Fixup #248

* Migrate from `chrono` to `time` to solve RUSTSEC-2020-0159 (#250)

`chrono` still hasn't found a solution to [RUSTSEC-2020-0159] whereas
`time` already solved its vulnerability to [RUSTSEC-2020-0071] by hiding
the affected functionality behind a cfg flag (not to be confused with a
`feature`, such `cfg`s can only be enabled through `RUSTFLAGS`).  At the
same time `chrono` is a superset of `time` even though this crate hardly
uses any functionality of it: only UTC time is needed which does not
suffer from aforementioned local time vulnerabilities.

[RUSTSEC-2020-0071]: https://rustsec.org/advisories/RUSTSEC-2020-0071
[RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159

Co-authored-by: Drazen Urch <drazen@urch.eu>

* Update Makefile

* Closes #245

* Bump aws-region

* s3 0.29.0

Co-authored-by: Marijn Suijten <marijns95@gmail.com>

* Provide better error information

Co-authored-by: Drazen Urch <drazen@urch.eu>
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
durch added a commit that referenced this pull request Mar 4, 2022
@durch
Squashed commit of the following:
8053540 
commit 7e5ecb7
Author: durch <durch@users.noreply.github.com>
Date:   Fri Mar 4 10:02:37 2022 +0100

    cargo fmt

commit d7f3ee7
Author: castaneai <castaneai@castaneai.net>
Date:   Fri Mar 4 17:57:31 2022 +0900

    Providing more detailed error when the put API fails (#257)

    * s3 0.29.0 (#253)

    * cargo: Move `tokio-stream` create behind the `with-tokio` feature (#248)

    `tokio-stream` has a dependency on `tokio` and is only used within the
    `request` module, which depends on the `with-tokio` feature.  As such,
    in order to completely prevent `tokio` from appearing in the crate
    graph, this crate must be marked optional and enabled when `with-tokio`
    is requested, omitted otherwise.

    Also includes two drive-by typo-fixes in the features section of the
    readme.

    * Fixup #248

    * Migrate from `chrono` to `time` to solve RUSTSEC-2020-0159 (#250)

    `chrono` still hasn't found a solution to [RUSTSEC-2020-0159] whereas
    `time` already solved its vulnerability to [RUSTSEC-2020-0071] by hiding
    the affected functionality behind a cfg flag (not to be confused with a
    `feature`, such `cfg`s can only be enabled through `RUSTFLAGS`).  At the
    same time `chrono` is a superset of `time` even though this crate hardly
    uses any functionality of it: only UTC time is needed which does not
    suffer from aforementioned local time vulnerabilities.

    [RUSTSEC-2020-0071]: https://rustsec.org/advisories/RUSTSEC-2020-0071
    [RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159

    Co-authored-by: Drazen Urch <drazen@urch.eu>

    * Update Makefile

    * Closes #245

    * Bump aws-region

    * s3 0.29.0

    Co-authored-by: Marijn Suijten <marijns95@gmail.com>

    * Provide better error information

    Co-authored-by: Drazen Urch <drazen@urch.eu>
    Co-authored-by: Marijn Suijten <marijns95@gmail.com>

commit 1259d34
Author: Marijn Suijten <marijn@traverseresearch.nl>
Date:   Fri Mar 4 09:56:18 2022 +0100

    aws-creds: Bump rust-ini to 0.18 (#256)

    Bumping rust-ini gets rid of a duplicate ordered-multimap for us.

commit c381ebf
Author: durch <durch@users.noreply.github.com>
Date:   Sat Feb 12 23:04:35 2022 +0100

    s3 0.29.0

commit ba783d2
Author: durch <durch@users.noreply.github.com>
Date:   Sat Feb 12 23:03:50 2022 +0100

    Bump aws-region

commit 8263e96
Author: durch <durch@users.noreply.github.com>
Date:   Sat Feb 12 22:47:17 2022 +0100

    Closes #245

commit c5a822c
Author: durch <durch@users.noreply.github.com>
Date:   Sat Feb 12 22:42:27 2022 +0100

    Update Makefile

commit a917f78
Author: Marijn Suijten <marijns95@gmail.com>
Date:   Sat Feb 12 22:38:54 2022 +0100

    Migrate from `chrono` to `time` to solve RUSTSEC-2020-0159 (#250)

    `chrono` still hasn't found a solution to [RUSTSEC-2020-0159] whereas
    `time` already solved its vulnerability to [RUSTSEC-2020-0071] by hiding
    the affected functionality behind a cfg flag (not to be confused with a
    `feature`, such `cfg`s can only be enabled through `RUSTFLAGS`).  At the
    same time `chrono` is a superset of `time` even though this crate hardly
    uses any functionality of it: only UTC time is needed which does not
    suffer from aforementioned local time vulnerabilities.

    [RUSTSEC-2020-0071]: https://rustsec.org/advisories/RUSTSEC-2020-0071
    [RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159

    Co-authored-by: Drazen Urch <drazen@urch.eu>

commit 10cf754
Author: durch <durch@users.noreply.github.com>
Date:   Sat Feb 12 22:37:42 2022 +0100

    Fixup #248

commit c1a174d
Author: Marijn Suijten <marijns95@gmail.com>
Date:   Sat Feb 12 22:07:58 2022 +0100

    cargo: Move `tokio-stream` create behind the `with-tokio` feature (#248)

    `tokio-stream` has a dependency on `tokio` and is only used within the
    `request` module, which depends on the `with-tokio` feature.  As such,
    in order to completely prevent `tokio` from appearing in the crate
    graph, this crate must be marked optional and enabled when `with-tokio`
    is requested, omitted otherwise.

    Also includes two drive-by typo-fixes in the features section of the
    readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarijnS95 @durch