Added delete function for system(s).

[bflad]

Allows you to delete system profiles from RHN Satellite.

[duritong]

Thanks for your contribution. In general this seems to be fine, but I would like to change 2 things:

• Imho we should not change system_ids. With map! we are changing the passed object system_ids, which I don't like that much, because people might use the content of the passed variable later in their code as well and expect it to be unchanged. We could also make that a simple oneliner:

base.default_call('system.deleteSystems',[*system_ids].collect{|i| i.to_i })

• Can you provide a spec for it? While the specs might be questionable as we generally mock the call, it will still provide an example of what we expect to get from the API and how the method should be used.

Thanks!

[bflad]

Added your change to use collect and not map! Also, added some spec tests for system delete which are green on my machine.

[duritong]

Thanks! One last thing: [*system_ids] makes that the test on Array is not anymore needed:

ree-head :001 > a = 1
 => 1 
ree-head :002 > b = [ a ]
 => [1] 
ree-head :003 > [*a] == [*b]
 => true 
ree-head :004 > [*a]
 => [1] 
ree-head :005 > [*b]
 => [1] 

[bflad]

Nice, didn't know about that operator before. Thanks!

[duritong]

Thanks!