Pass the XMLHttpRequest to the send method

durran · Jan 17, 2012 · 9ab2a20 · 9ab2a20
1 parent b593986
commit 9ab2a20
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/public/javascripts/jquery.attach.js b/public/javascripts/jquery.attach.js
@@ -176,7 +176,7 @@ var Attach = {};
   */
   Attach.readSuccess = function(event) {
     var uploader = new Attach.Uploader(event.target);
-    uploader.send();
+    uploader.send(new XMLHttpRequest());
   };
 
   /*
@@ -224,10 +224,9 @@ var Attach = {};
   /*
   * Send the file to the server via xhr.
   *
-  *   uploader.send();
+  *   uploader.send(new XmlHttpRequest());
   */
-  Attach.Uploader.prototype.send = function() {
-    var request = new XMLHttpRequest();
+  Attach.Uploader.prototype.send = function(request) {
     this.attachEvents(request);
     this.prepareRequest(request);
     request.send(this.file());

diff --git a/spec/javascripts/jquery.attach_spec.js b/spec/javascripts/jquery.attach_spec.js
@@ -128,5 +128,28 @@ describe("jquery Attach", function() {
         expect(uploader.file()).toEqual(file);
       });
     });
+
+    describe("#send", function() {
+
+      var request;
+      var reader;
+
+      beforeEach(function() {
+        reader = new Attach.Reader(file, url);
+        Attach.readers.push(reader);
+        request = new XMLHttpRequest();
+        spyOn(request, "send");
+      });
+
+      it("reads the file", function() {
+        uploader.send(request);
+        expect(request.send).toHaveBeenCalledWith(file);
+      });
+
+      it("pops the reader off the stack", function() {
+        uploader.send(request);
+        expect(Attach.readers.length).toEqual(0);
+      });
+    });
   });
 });