Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check quorum per each reduction step on agreement message verification #1373

Closed
goshawk-3 opened this issue Apr 13, 2022 · 0 comments · Fixed by #1374
Closed

Check quorum per each reduction step on agreement message verification #1373

goshawk-3 opened this issue Apr 13, 2022 · 0 comments · Fixed by #1374
Assignees

Comments

@goshawk-3
Copy link
Contributor

Describe the bug
Currently, quorum check is based a sum of all voters.

Expected behaviour
Agreement verification should ensure quorum threshold is reached for both reduction steps.

Logs

total_votes of step:3 should be 11 but not "total_votes":23

{"bitset":479,"event":"agreement_received","hash":"62b29d1a45...f42c463eef","level":"info","msg":"","process":"consensus","round":237998,"step":2,"time":"2022-04-13T10:07:22Z","total_votes":12,"voted_len":8}
{"bitset":371,"event":"agreement_received","hash":"62b29d1a45...f42c463eef","level":"info","msg":"","process":"consensus","round":237998,"step":3,"time":"2022-04-13T10:07:22Z","total_votes":23,"voted_len":6}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant