Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify block certificate prior to broadcast #1446

Closed
goshawk-3 opened this issue Jul 28, 2022 · 2 comments · Fixed by #1447
Closed

Verify block certificate prior to broadcast #1446

goshawk-3 opened this issue Jul 28, 2022 · 2 comments · Fixed by #1447
Assignees

Comments

@goshawk-3
Copy link
Contributor

Describe the bug
On receiving a block from Kadcast network, we used to fully verify it before re-propagating it to the next bucket. Now to speed up block broadcast to all provisioners, we re-propagate it without any checks.

Checking a certificate and block header should be a precondition for a block propagation.

@herr-seppia
Copy link
Member

In this case, txs root should be reintroduced

@goshawk-3
Copy link
Contributor Author

In this case, txs root should be reintroduced

This should be addressed with a separate issue that may also take into account the backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants