Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor eventfilter and accumulator packages defensively #21

Closed
autholykos opened this issue Aug 13, 2019 · 2 comments
Closed

Refactor eventfilter and accumulator packages defensively #21

autholykos opened this issue Aug 13, 2019 · 2 comments
Assignees
@autholykos
Labels
type:rfc Changing the behaviour of something already defined

Comments

@autholykos
Copy link
Member

Current way the accumulator and eventfilter prevent race conditions is by making heavy used of state management in the accumulator. It is possible to refactor the packages defensively to keep the same resilience against race conditions but without excessive locking.
@autholykos autholykos added type:rfc Changing the behaviour of something already defined Node:Consensus labels Aug 13, 2019
@autholykos autholykos self-assigned this Aug 14, 2019
@autholykos
Copy link
Member Author

Both the accumulator and the eventfilter are the result of trying to excessively abstract the reducer and the agreement components. A refactor attempt should probably try and decouple the code as much as possible, limiting the DRY principle to more reasonable levels and promoting clarity and readability

@autholykos autholykos mentioned this issue Sep 4, 2019
Closed
@autholykos
Copy link
Member Author

duplicate of #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@autholykos autholykos

Labels
type:rfc Changing the behaviour of something already defined
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@autholykos