Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify transactions and block structures between core and wallet packages #51

Closed
jules opened this issue Aug 21, 2019 · 1 comment · Fixed by #59
Closed

Unify transactions and block structures between core and wallet packages #51

jules opened this issue Aug 21, 2019 · 1 comment · Fixed by #59
Assignees
@jules
Labels
type:rfc Changing the behaviour of something already defined

Comments

@jules
Copy link
Contributor

jules commented Aug 21, 2019

This would save us from duplicate code, and conversion issues when the wallet package is externalized.
@jules jules added type:rfc Changing the behaviour of something already defined Node:Blockchain labels Aug 21, 2019
@jules jules self-assigned this Aug 21, 2019
@jules
Copy link
Contributor Author

jules commented Aug 21, 2019

This is needed for #47, as it makes the transition a lot smoother.

@jules jules mentioned this issue Aug 26, 2019
Merged
@jules jules closed this as completed in #59 Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jules jules

Labels
type:rfc Changing the behaviour of something already defined
Projects
None yet
Milestone
No milestone
1 participant
@jules