#ITEM 1 - Review Phase 1 of Kalinski's algorithm. #15
Comments
Phase I is working correctly working now since the tests performed by @Bounce23 and me in 035777b. But an error has appeared on the Phase II while we perform the addition for |
Reopened since errors still appearing on the implementation. |
Errors are seemingly inexplicable. Alongside this, there is no working example of the Kalinski algorithm, nor any means to contact him. I will build an inversion on double chain addition for use instead. Although this is relatively more difficult than the Algorithm, it WILL work and it provides us with constant time operations, meaning no need for later optimisation in that regard. |
Since @Bounce23 said that we could go for an addition chain algorithm which will enable us to perform inversion operations in CTime. So this closes dusk-network#15 dusk-network#17 and dusk-network#14 for now.
As mentioned on last commits this will remain closed until addition chain implementations are found or discarded. |
The optimum method of Modular inverse was always this algorithm as using addition chains required defining all of the temporary t value field elements up to and including 2^260. |
This definitely closes: dusk-network#17, dusk-network#15 and #9 and opens the door for the development of dusk-network#14 . - Implemented more exhaustive tests for `kalinski_inverse()` function, which performs the modular inverse of the given `FieldElement`. - Added doc comments for `half()` and `plus_p_and_half()` functions. - Removed some debugging prints.
Since the algorithm implemented on #9 was passing the tests, we thought that
Phase I
was working correctly.But while working on #14 we realized the function only works for the tested value surprisingly ..
So now it's time to find the bug that it's affecting
Phase I
of the Kalinski's algorithm.The text was updated successfully, but these errors were encountered: