Session Commits Persistence Implementation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszm
added
mark:next
miloszm
requested review from
krl and
ureeves
and removed request for
ureeves
herr-seppia
removed
the
mark:next
krl
approved these changes
Oct 14, 2022
vmx/src/commit.rs
Outdated
| @@ -147,6 +197,46 @@ impl SessionCommits { | |||
| None => Err(SessionError("unknown session commit id".into())), | |||
| } | |||
| } | |||
|
|
|||
| pub fn read<P: AsRef<Path>>(path: P) -> Result<Self, Error> { | |||
There was a problem hiding this comment.
naming here, using "read/write" is very generic and overlaps with the Read and Write traits unnecessarily, consider store/restore or something similar (in all cases where read/write is used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session Commits Persistence Implementation
Solves issue #89