Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing qfixed and qvar in check_circuit_satisfied #541

Closed
ChihChengLiang opened this issue Jun 16, 2021 · 1 comment
Closed

Missing qfixed and qvar in check_circuit_satisfied #541

ChihChengLiang opened this issue Jun 16, 2021 · 1 comment
Labels
fix:bug Something isn't working

Comments

@ChihChengLiang
Copy link

What's wrong

The variable k in the check_circuit_satisfied should check if constraints related to q_fixed_group_add and q_variable_group_add selectors are satisfied, but the check is unimplemented now.

How can we fix it

Add qfixed and qvar checks to the variable k
@CPerezz CPerezz added the fix:bug Something isn't working label Jun 17, 2021
@ChihChengLiang ChihChengLiang mentioned this issue Jun 23, 2021
Closed
3 tasks
@moCello
Copy link
Member

moCello commented Jan 3, 2024

Not applicable anymore since check_circuit_satisfied doesn't exist anymore

@moCello moCello closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix check_circuit_satisfied ChihChengLiang/plonk
3 participants
@ChihChengLiang @CPerezz @moCello